test: write the federation regression tests [WPB-19988]#21440
Open
zhannach wants to merge 17 commits into
Open
test: write the federation regression tests [WPB-19988]#21440zhannach wants to merge 17 commits into
zhannach wants to merge 17 commits into
Conversation
This way it's possible to connect to federated users
zhannach
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
|
|
||
| getUserAvailabilityIcon(fullName: string) { | ||
| return this.getLocatorByUser(fullName).getByTestId('status-availability-icon'); | ||
| getParticipant(fullName: string) { |
markbrockhoff
requested changes
Jun 3, 2026
Comment on lines
+251
to
+257
| const messageNormalUser = normalUserPages.conversation().getMessage({sender: normalUser}); | ||
| await expect(messageNormalUser).toBeVisible(); | ||
| await expect(federatedUserPages.conversation().getMessage({sender: normalUser})).toBeVisible(); | ||
|
|
||
| await normalUserPages.conversation().deleteMessage(messageNormalUser, 'Everyone'); | ||
| await expect(messageNormalUser).not.toBeVisible(); | ||
| await expect(federatedUserPage.getByTestId('element-message-delete')).toBeVisible(); |
Collaborator
There was a problem hiding this comment.
Why use the "element-message-deleted" test id? How about checking the message is there and then expecting it to be gone after deletion? :)
Suggested change
| const messageNormalUser = normalUserPages.conversation().getMessage({sender: normalUser}); | |
| await expect(messageNormalUser).toBeVisible(); | |
| await expect(federatedUserPages.conversation().getMessage({sender: normalUser})).toBeVisible(); | |
| await normalUserPages.conversation().deleteMessage(messageNormalUser, 'Everyone'); | |
| await expect(messageNormalUser).not.toBeVisible(); | |
| await expect(federatedUserPage.getByTestId('element-message-delete')).toBeVisible(); | |
| const messageNormalUser = normalUserPages.conversation().getMessage({sender: normalUser}); | |
| const messageFederatedUser = federatedUserPages.conversation().getMessage({sender: normalUser}); | |
| await expect(messageNormalUser).toBeVisible(); | |
| await expect(messageFederatedUser).toBeVisible(); | |
| await normalUserPages.conversation().deleteMessage(messageNormalUser, 'Everyone'); | |
| await expect(messageNormalUser).not.toBeVisible(); | |
| await expect(messageFederatedUser).not.toBeVisible(); |
Collaborator
Author
There was a problem hiding this comment.
It was implemented according to the requirements:
User A deletes previous text message for all users
User B sees deleted message
Comment on lines
+354
to
+358
| let backupName: string; | ||
| await test.step('Create and save backup for the normal user', async () => { | ||
| await normalUserComponents.conversationSidebar().clickPreferencesButton(); | ||
| backupName = await createAndSaveBackup(testInfo, normalUserPageManager); | ||
| }); |
Collaborator
There was a problem hiding this comment.
🎨 I learned that this was possible from you in one of your previous PRs ;)
Suggested change
| let backupName: string; | |
| await test.step('Create and save backup for the normal user', async () => { | |
| await normalUserComponents.conversationSidebar().clickPreferencesButton(); | |
| backupName = await createAndSaveBackup(testInfo, normalUserPageManager); | |
| }); | |
| const backupName = await test.step('Create and save backup for the normal user', async () => { | |
| await normalUserComponents.conversationSidebar().clickPreferencesButton(); | |
| return await createAndSaveBackup(testInfo, normalUserPageManager); | |
| }); |
Comment on lines
+226
to
+230
| await createGroup(normalUserPages, groupName, []); | ||
| await normalUserPages.conversationList().getConversation(groupName).open(); | ||
| await normalUserPages.conversation().toggleGroupInformation(); | ||
| await normalUserPages.conversationDetails().clickAddPeopleButton(); | ||
| await normalUserPages.conversationDetails().addUsersToConversation([federatedUser.fullName]); |
Collaborator
There was a problem hiding this comment.
Is there a specific reason why you're adding the federatedUser like this instead of just passing him to the users array?
Suggested change
| await createGroup(normalUserPages, groupName, []); | |
| await normalUserPages.conversationList().getConversation(groupName).open(); | |
| await normalUserPages.conversation().toggleGroupInformation(); | |
| await normalUserPages.conversationDetails().clickAddPeopleButton(); | |
| await normalUserPages.conversationDetails().addUsersToConversation([federatedUser.fullName]); | |
| await createGroup(normalUserPages, groupName, [federatedUser]); |
Collaborator
Author
There was a problem hiding this comment.
Yes, the requirements were to create an empty group and then invite the federated user to it. However, since there are no specific checks during this step, I'd like to see if we can align on simplifying it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces new Federation regression test suite.
These tests validate key federation capabilities, including asset sharing, cross-backend communication, backup imports, and real-time audio/video calls between different backend environments.
Changes: