Eventually restart file loading#533
Merged
wrefgtzweve merged 6 commits intowiremod:masterfrom Feb 25, 2026
Merged
Conversation
thegrb93
approved these changes
Feb 24, 2026
wrefgtzweve
approved these changes
Feb 25, 2026
Remove AdvDupe2.File, it's unused in the codebase and never set anywhere Set .Uploading to false, not nil
Contributor
Author
|
Tested, the uploading keeps working as normal after forced to restart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fallback in case advdupe2 gets stuck uploading a dupe to the server for whatever reason.
This clip shows the issue that spurred this pr, file uploading getting stuck.
https://www.youtube.com/watch?v=VaRC0m2j3bA
Extremely frustrating and the only option seems to be to rejoin.
Very much open to feedback, changes from maintainers.
There might be a better way to do this, but these changes seem to work without issue in testing.