Fix NoClassDefFoundError in ConfigAP#479
Open
Minecraftalus wants to merge 1 commit into
Open
Conversation
In certain cases when built on case insensitive filesystems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In certain cases when built on case insensitive filesystems, the generated config will throw a NoClassDefFoundError.
Currently nested classes are being checked for naming conflicts but not casing conflicts. For example a nested config section
HUD hud = new HUD();results in an inner interface namedHUDand inner class namedHud, which aren't equal so no _ is appended. During compilation these files overwrite eachother leading to a NoClassDefFoundError.Switching to equalsIgnoreCase catches both naming and casing conflicts.