Getting Strings

[ejohnstown]

1. Rewrite GetString() and GetStringAlloc() in terms of GetStringRef().
2. Change GetStringRef() to allow for 0 length strings.
3. Update DoChannelRequest() to use GetStringAlloc() when reading the modes from the packet.

Fixes ZD20321.

[Copilot]

Pull request overview

This PR refactors string extraction functions to use a common implementation and fixes handling of zero-length strings. The changes consolidate GetString() and GetStringAlloc() to use GetStringRef() as their foundation, update GetStringRef() to properly handle zero-length strings, and modify DoChannelRequest() to use GetStringAlloc() for reading terminal modes.

Key Changes

• Refactored GetString() and GetStringAlloc() to delegate to GetStringRef() instead of duplicating buffer extraction logic
• Updated GetStringRef() to handle zero-length strings by setting the pointer to NULL when length is zero
• Changed DoChannelRequest() to use GetStringAlloc() for terminal modes instead of GetStringRef() followed by manual memory allocation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.