Skip to content

ignore hook removal when repo is already deleted on github #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuxmainy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ignore hook removal when repo is already deleted on github #5822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45a94f
ignore hook removal when repo is already deleted on github
tuxmainy Dec 4, 2025
85dbaac
Merge branch 'woodpecker-ci:main' into woodpecker-5140
tuxmainy Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions server/forge/github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,13 @@ func (c *client) Deactivate(ctx context.Context, u *model.User, r *model.Repo, l
client := c.newClientToken(ctx, u.AccessToken)
hooks, _, err := client.Repositories.ListHooks(ctx, r.Owner, r.Name, nil)
if err != nil {
// ignore HTTP/404, which means that the repository is already deleted on github
// so we don't need to remove any hooks, just go out
githubErr, isGithubErrorResponse := err.(*github.ErrorResponse)
if isGithubErrorResponse && githubErr.Response.StatusCode == 404 {
return nil
}

return err
}
match := matchingHooks(hooks, link)
Expand Down