Skip to content

Conversation

@adalpari
Copy link
Contributor

Description

YouTube added a ToS requirement that the HTTP referrer be included for all embeds. If it's not, the embed displays an error. We were aware of this in the context of the experimental editor and planned to address it, but because it's in production, this is now moved to the top of the queue.

Testing instructions

  1. Open the Reader
  2. Search for a post with an embedded YouTube video. You can directly search "https://ma.tt/2025/11/bending-spoons/" if that helps
  • Verify the video is embedded correctly and you can wach it

Before/After
Screenshot 2025-11-13 at 09 10 32 / Screenshot 2025-11-13 at 09 41 17

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 13, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@sonarqubecloud
Copy link

@adalpari adalpari marked this pull request as ready for review November 13, 2025 11:11
@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
FlavorJalapeno
Build TypeDebug
Versionpr22349-48701d6
Commit48701d6
Direct Downloadjetpack-prototype-build-pr22349-48701d6.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
FlavorJalapeno
Build TypeDebug
Versionpr22349-48701d6
Commit48701d6
Direct Downloadwordpress-prototype-build-pr22349-48701d6.apk
Note: Google Login is not supported on these builds.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 39.86%. Comparing base (8addd1e) to head (48701d6).
⚠️ Report is 1 commits behind head on release/26.3.1.

Files with missing lines Patch % Lines
.../wordpress/android/ui/reader/ReaderPostRenderer.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/26.3.1   #22349   +/-   ##
===============================================
  Coverage           39.86%   39.86%           
===============================================
  Files                2168     2168           
  Lines              102894   102894           
  Branches            14840    14840           
===============================================
  Hits                41015    41015           
  Misses              58399    58399           
  Partials             3480     3480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected :shipit:

@adalpari adalpari merged commit 087b08d into release/26.3.1 Nov 13, 2025
25 checks passed
@adalpari adalpari deleted the fix/fix-broken-reader-YouTube-embeds-hotfix branch November 13, 2025 15:06
crazytonyli pushed a commit that referenced this pull request Nov 13, 2025
* Bump version number

* Setting the baseUrl ad a referrer when loading the reader webview url (#22349)

---------

Co-authored-by: Adalberto Plaza <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants