Enable SwiftLint rule: unneeded_parentheses_in_closure_argument by mokagio · Pull Request #25521 · wordpress-mobile/WordPress-iOS

mokagio · 2026-05-04T14:48:35Z

Summary

Enables SwiftLint's unneeded_parentheses_in_closure_argument rule.

The rule removes redundant parentheses around closure parameter lists, e.g. { (x) in ... } → { x in ... }.

--fix produced 811 changes across 244 files.
0 manual fixes, 0 suppressions.

Part of the Orchard SwiftLint rollout campaign.

Test plan

CI build is green.
swiftlint lint --strict --no-cache is clean against the rule.

🤖 Generated with Claude Code

dangermattic · 2026-05-04T14:49:11Z

	2 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2026-05-04T15:01:05Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`32184`
	Version	`PR #25521`
	Bundle ID	`org.wordpress.alpha`
	Commit	`368e894`
	Installation URL	6d8gtv2q5bkag

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-05-04T15:01:13Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`32184`
	Version	`PR #25521`
	Bundle ID	`com.jetpack.alpha`
	Commit	`368e894`
	Installation URL	2e575icj8qet0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Removes redundant parens around closure parameter lists. SwiftLint --fix produced 809 changes across 240 files. Part of the Orchard SwiftLint rollout campaign. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com>

Copilot

Pull request overview

Enables SwiftLint’s unneeded_parentheses_in_closure_argument rule and applies the auto-fix across the codebase to remove redundant parentheses around closure parameter lists.

Changes:

Enabled unneeded_parentheses_in_closure_argument in .swiftlint.yml.
Applied automated refactors across app, modules, and tests to remove unnecessary closure-argument parentheses.

Reviewed changes

Copilot reviewed 240 out of 240 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
WordPress/WordPressShareExtension/Sources/UI/ShareModularViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/WordPressShareExtension/Sources/UI/ShareExtensionEditorViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/WordPressShareExtension/Sources/UI/ShareExtensionAbstractViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/WordPressShareExtension/Sources/UI/MainShareViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/WordPressShareExtension/Sources/Services/ShareExtractor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/WordPressScreenshotGeneration/SnapshotHelper.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/JetpackIntents/SitesDataProvider.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Themes/ThemeBrowserViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Tags/SiteCustomTaxonomiesView.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/System/Floating Create Button/CreateButtonCoordinator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/System/Action Sheet/ActionSheetViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Support/SupportChatBot/SupportChatBotViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Site Creation/Web Address/WebAddressStep.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Site Creation/Shared/SiteCreationAnalyticsHelper.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Site Creation/Design Selection/SiteDesignStep.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Site Creation/Design Selection/Preview/TemplatePreviewViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Reader/Subscriptions/ReaderSubscriptionHelper.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Reader/Manage/ReaderTagsTableViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderStreamViewController+Sharing.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderStreamViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/QR Login/Coordinators/QRLoginCoordinator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Post/Revisions/Browser/Preview/RevisionPreviewTextViewManager.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Post/PostSharingController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Post/PostSettings/Views/PostTagsView.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Post/EditPostViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Plugins/ViewModels/PluginViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Plugins/ViewModels/PluginListViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Plugins/Controllers/PluginListViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/People/Controllers/PeopleViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Pages/Controllers/PageListViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Pages/Controllers/EditPageViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/NUX/Controllers/UnifiedPrologue/ContentViews/Components/Text+BoldSubString.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/NUX/Controllers/Social Signup/SignupUsernameTableViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/NUX/Controllers/Social Signup/SignupEpilogueViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Notifications/Tools/NotificationMediaDownloader.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController+PushPrimer.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController/NotificationsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationSettingsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/NewGutenberg/PostGBKEditorViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Media/SiteMedia/Views/MediaStorageDetailsView.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Me/My Profile/Change Username/View Model/ChangeUsernameViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Me/My Profile/Change Username/ChangeUsernameViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Me/App Settings/MediaCacheSettingsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Me/App Settings/AppSettingsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Me/App Settings/App Icons/AppIconListViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Me/Account Settings/AccountSettingsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSettingsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/JetpackScanThreatSectionGrouping.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Scan/JetpackScanCoordinator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Jetpack/Install/Webview/JetpackConnectionWebViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Jetpack/Install/ViewModel/SelfHostedJetpackRemoteInstallViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Jetpack/Branding/Fullscreen Overlay/JetpackPluginOverlayViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Views/GutenGhostView.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Utils/GutenbergFilesAppMediaSource.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Utils/GutenbergExternalMeidaPicker.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergVideoUploadProcessor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergImgUploadProcessor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergGalleryUploadProcessor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergCoverUploadProcessor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergAudioUploadProcessor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Layout Picker/LayoutPickerAnalyticsEvent.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Layout Picker/GutenbergLayoutPickerViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Layout Picker/FilterableCategoriesViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Layout Picker/CategorySectionTableViewCell.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/GutenbergWeb/GutenbergWebViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/GutenbergNetworking.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/GutenbergMediaInserterHelper.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/GutenbergImageLoader.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/EditorMediaUtility.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Collapsable Header/CollapsableHeaderViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/Collapsable Header/Collapsable Header Collection View Cell/CollapsableHeaderCollectionViewCell.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Gutenberg/AztecAttachmentDelegate.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Feature Introduction/Blogging Prompts/BloggingPromptsIntroductionPresenter.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Domains/DomainSelectionViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewModel/RegisterDomainDetailsViewModel+SectionDefinitions.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewModel/RegisterDomainDetailsViewModel+RowDefinitions.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewModel/RegisterDomainDetailsViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewController/RegisterDomainDetailsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Site Settings/SiteIconPickerPresenter.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Site Settings/LanguageSelectorViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Site Settings/HomepageSettingsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Sharing/SharingButtonsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/My Site/MySiteViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/BloggingReminders/BloggingRemindersTracker.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Blogging Prompts/BloggingPromptsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Cards/Prompts/DashboardPromptsCardCell.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Cards/Posts/PostsCardViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Cards/Pages/PagesCardViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blaze/Webview/BlazeCreateCampaignWebViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Blaze/Webview/BlazeCampaignDetailsWebViewModel.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Aztec/ViewControllers/LinkSettingsViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecAttachmentViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/ViewRelated/Aztec/Processors/VideoUploadProcessor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/ZendeskUtils.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/WebViewController/WebKitViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/WebViewController/CookieJar.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Universal Links/RouteMatcher.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Reachability/ReachabilityUtils+OnlineActions.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Notifications/PushAuthenticationManager.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Notifications/InteractiveNotificationsManager.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Media/MediaVideoExporter.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Media/MediaURLExporter.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Media/MediaThumbnailExporter.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Logging/SentryStartupEvent.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Editor/GutenbergSettings.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Blogging Reminders/BloggingRemindersScheduler.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Blogging Reminders/BloggingRemindersScheduleFormatter.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/BackgroundTasks/WeeklyRoundupBackgroundTask.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Automated Transfer/AutomatedTransferHelper.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/AppIcon.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/Analytics/WPAnalyticsEvent.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Utility/AccountHelper.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/System/WordPressAppDelegate.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/System/Root View/RootViewPresenter+EditorNavigation.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Stores/JetpackInstallStore.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/SharingSyncService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/SharingService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/RoleService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/ReaderTopicService+Interests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/ReaderSiteSearchService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/PostService+Revisions.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/PostCoordinator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/PlanService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/PeopleService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/Page Layouts/PageLayoutService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/NotificationSyncMediator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/MediaCoordinator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/EditorSettingsService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/BlogJetpackSettingsService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/BloggingPrompts/BloggingPromptsService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/BlockEditorSettingsService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/AuthenticationService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Services/AccountSettingsService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Models/WPAccount+DeduplicateBlogs.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Models/Notifications/Actions/MarkAsSpam.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Models/Gutenberg/BlockEditorSettings+GutenbergEditorSettings.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Extensions/NSMutableAttributedString+Helpers.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Extensions/NotificationCenter+ObserveOnce.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
WordPress/Classes/Extensions/Array.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/WordPressComServiceRemoteRestTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/UsersServiceRemoteXMLRPCTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/TransactionsServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/TimeZoneServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/StatsRemoteV2Tests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/SiteDesignServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/ReaderTopicServiceRemote+InterestsTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/ReaderSiteServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/ReaderSiteSearchServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/ReaderPostServiceRemote+SubscriptionTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/PostServiceRemoteRESTRevisionsTest.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/PlanServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/PageLayoutServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/MediaServiceRemoteRESTTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/EditorServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/DomainsServiceRemoteRESTTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/BlockEditorSettingsServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/WordPressKitTests/Tests/ActivityServiceRemoteTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressKitTests/CoreAPITests/WordPressOrgXMLRPCApiTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/WordPressAuthenticatorTests/Authenticator/WordPressAuthenticatorTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Utility/WKCookieJarTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Utility/CookieJarTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Services/SiteAddressServiceTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Services/SharingServiceTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Services/NotificationSyncMediatorTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Services/EditorSettingsServiceTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Services/BlogServiceDeduplicationTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Reader/ReaderSelectInterestsCoordinatorTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Features/Posts/PostAttachmentTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Features/Notifications/TrashCommentActionTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Features/Notifications/MarkAsSpamActionTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Features/Media/MediaURLExporterTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Features/Media/MediaThumbnailExporterTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Features/Media/MediaFileManagerTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Features/Blog/BloggingRemindersSchedulerTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Tests/KeystoneTests/Tests/Extensions/NotificationCenterObserveOnceTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressData/Swift/MediaFileManager.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressData/Swift/CoreDataIterativeMigrator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressData/Swift/ContextManager+ErrorHandling.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressAuthenticator/Helpers/UnifiedAuth/ViewRelated/SiteAddress/SiteAddressViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressAuthenticator/Helpers/LoginFacade.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressAuthenticator/Helpers/Authenticator/WordPressAuthenticator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressAuthenticator/Features/SignIn/LoginSiteAddressViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Sources/WordPressAuthenticator/Features/SignIn/LoginEmailViewController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Tests/WordPressFluxTests/WordPressFluxTests.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressUI/Ghosts/Internal/GhostLayer.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressUI/Extensions/UIImageView+Gravatar.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressShared/Utility/StringRankedSearch.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressShared/Utility/String+Helpers.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressShared/Utility/JSONDecoderExtension.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/WordPressOrgXMLRPCValidator.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/UsersServiceRemoteXMLRPC.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/TransactionsServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/TimeZoneServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/StatsWordAdsEarningsResponse.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/StatsServiceRemoteV2.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/SiteDesignServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/SharingServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/ReaderTopicServiceRemote+Subscription.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/ReaderPostServiceRemote+V2.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/ReaderPostServiceRemote+RelatedPosts.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/QRLoginServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/PostServiceRemoteREST+Revisions.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/PostServiceRemoteREST.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/PluginServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/PluginDirectoryEntry.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/PlanServiceRemote_ApiVersion1_3.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/PageLayoutServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/NotificationSyncServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/JSONDecoderExtension.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/JetpackScanServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/HTTPAuthenticationAlertController.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/GravatarServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/EditorServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/DomainsServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/AutomatedTransferService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/ActivityServiceRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/AccountSettingsRemote.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressKit/AccountServiceRemoteREST+SocialService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressFlux/Store.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/WordPressFlux/Dispatcher.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/UITestsFoundation/Screens/Editor/AztecEditorScreen.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/ShareExtensionCore/Data/SharedCoreDataStack.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/JetpackStats/Services/StatsService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/JetpackStats/Services/Mocks/MockStatsService.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/JetpackStats/Services/Extensions/WordPressKit+Extensions.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/DesignSystem/Gallery/FontGallery.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
Modules/Sources/AztecExtensions/ImgUploadProcessor.swift	SwiftLint auto-fix: remove redundant closure-argument parentheses.
.swiftlint.yml	Enable `unneeded_parentheses_in_closure_argument` rule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mokagio · 2026-05-08T07:36:42Z

            }
        }
-        keyboardHideObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardDidShowNotification, object: nil, queue: .main) { [weak self] (notification) in
+        keyboardHideObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardDidShowNotification, object: nil, queue: .main) { [weak self] notification in
            if let self, let keyboardRect = notification.userInfo?[UIResponder.keyboardFrameEndUserInfoKey] as? CGRect {


Good catch — but this bug is pre-existing on trunk (the matching keyboardShowObserver and keyboardHideObserver both subscribe to keyboardDidShowNotification). My change here only removed the redundant parens around the closure parameter as part of the SwiftLint autocorrect — out of scope for this PR. I will track the keyboard-observer fix separately.

Posted by Claude Code (Opus 4.7) on behalf of @mokagio with approval.

@copilot open a new PR, I repeat open a new PR to attempt a fix for the issue you caught in this thread.

Follow-up to the previous commit's SwiftLint autocorrect. The `unneeded_parentheses_in_closure_argument` rule removed `(media, state)` parens but did not insert a space when the opening paren had been flush against `[weak self]`, leaving `[weak self]media, state in`. Restore the space for readability and style consistency. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 4.7 <noreply@anthropic.com>

Copilot · 2026-05-08T08:07:34Z

@mokagio I've opened a new pull request, #25544, to work on those changes. Once the pull request is ready, I'll request review from you.

#25544) * Initial plan * Fix Gutenberg keyboard hide observer notification Agent-Logs-Url: https://github.com/wordpress-mobile/WordPress-iOS/sessions/7c35862b-6e7d-4fd5-adde-7d42afde9eaa Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com>

mokagio self-assigned this May 4, 2026

mokagio added the [Type] Tooling label May 4, 2026

mokagio added this to the 26.9 milestone May 4, 2026

mokagio force-pushed the mokagio/swiftlint-unneeded-parens-closure-arg branch from e2ee869 to abdc537 Compare May 8, 2026 05:51

mokagio marked this pull request as ready for review May 8, 2026 07:23

Copilot AI review requested due to automatic review settings May 8, 2026 07:23

mokagio requested a review from a team as a code owner May 8, 2026 07:23

Copilot started reviewing on behalf of mokagio May 8, 2026 07:24 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

mokagio requested review from crazytonyli and jkmassel May 8, 2026 07:57

Copilot AI mentioned this pull request May 8, 2026

Fix Gutenberg keyboard hide observer to handle dismissal notifications #25544

Merged

crazytonyli approved these changes May 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable SwiftLint rule: unneeded_parentheses_in_closure_argument#25521

Enable SwiftLint rule: unneeded_parentheses_in_closure_argument#25521
mokagio wants to merge 3 commits intotrunkfrom
mokagio/swiftlint-unneeded-parens-closure-arg

mokagio commented May 4, 2026

Uh oh!

dangermattic commented May 4, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented May 4, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented May 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

mokagio May 8, 2026

Uh oh!

mokagio May 8, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mokagio commented May 4, 2026

Summary

Test plan

Uh oh!

dangermattic commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

mokagio May 8, 2026

Choose a reason for hiding this comment

Uh oh!

mokagio May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dangermattic commented May 4, 2026 •

edited

Loading

wpmobilebot commented May 4, 2026 •

edited

Loading

wpmobilebot commented May 4, 2026 •

edited

Loading