Enable SwiftLint rule: contains_over_first_not_nil

[mokagio]

Summary

Enables SwiftLint's contains_over_first_not_nil rule and rewrites the 13 existing violations.

The rule prefers xs.contains { ... } over xs.first(where: { ... }) != nil (and the firstIndex variant), which is a performance and clarity win.

• 13 violations fixed across 9 files.
• 0 suppressions.
• Some inverted forms (first { } == nil) were rewritten with !contains / allSatisfy depending on what reads cleanest.
• The rewrite is type-preserving (Bool→Bool) — local build deferred to CI.

Part of the Orchard SwiftLint rollout campaign.

Test plan

• CI build is green.
• swiftlint lint --strict --no-cache is clean against the rule.

🤖 Generated with Claude Code

[dangermattic]

	1 Message
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	32099
	Version	PR #25523
	Bundle ID	org.wordpress.alpha
	Commit	86157be
	Installation URL	77jeinuoimd60

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	32099
	Version	PR #25523
	Bundle ID	com.jetpack.alpha
	Commit	86157be
	Installation URL	0nqsd7tkl6tjg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[Copilot]

Pull request overview

Enables SwiftLint’s contains_over_first_not_nil opt-in rule and updates existing boolean checks to use contains(where:) (or equivalent !contains / allSatisfy) instead of first(where:) != nil / == nil, improving clarity and avoiding intermediate optional handling across the app and data layers.

Changes:

• Enabled the contains_over_first_not_nil SwiftLint rule in .swiftlint.yml.
• Replaced first(where:) != nil patterns with contains(where:) across multiple UI and store files.
• Rewrote inverted forms (first(...) == nil) to !contains / allSatisfy in a few status-aggregation helpers.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
.swiftlint.yml	Opts into contains_over_first_not_nil to enforce the preferred pattern moving forward.
WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift	Uses contains(where:) for Automattic email detection.
WordPress/Classes/ViewRelated/Stats/Insights/TabbedTotalsCell.swift	Uses !contains(where:) to determine whether any tab has data.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController/NotificationsViewController.swift	Uses contains(where:) to enable/disable “Mark All As Read”.
WordPress/Classes/Stores/StatsStore+Cache.swift	Uses contains(where:) to determine whether any requested type has cached data.
WordPress/Classes/Stores/StatsRevampStore.swift	Uses contains(where:) in fetching status aggregation logic.
WordPress/Classes/Stores/StatsPeriodStore.swift	Uses allSatisfy for “none loading” / “all error” status checks.
WordPress/Classes/Stores/StatsInsightsStore.swift	Uses contains(where:) (and !contains) on reflected status lists for fetching state checks.
WordPress/Classes/Extensions/NSFetchedResultsController+Helpers.swift	Uses contains(where:) on sections to determine emptiness.
Sources/WordPressData/Swift/AbstractPost.swift	Uses contains(where:) to detect permanently failed media.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.