Enable SwiftLint rule: contains_over_range_nil_comparison

[mokagio]

Summary

Enables SwiftLint's contains_over_range_nil_comparison rule.

The rule prefers s.contains(...) over s.range(of:) != nil (and == nil), which is a clarity win.

• See commit message for the violation count and any rewrites.
• The change is type-preserving (Bool→Bool) — local build deferred to CI.

Part of the Orchard SwiftLint rollout campaign.

Test plan

• CI build is green.
• swiftlint lint --strict --no-cache is clean against the rule.

🤖 Generated with Claude Code

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	32165
	Version	PR #25524
	Bundle ID	com.jetpack.alpha
	Commit	1fe344f
	Installation URL	1is1d4r759opo

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	32165
	Version	PR #25524
	Bundle ID	org.wordpress.alpha
	Commit	1fe344f
	Installation URL	4b7do8eop5sho

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[Copilot]

Pull request overview

Enables SwiftLint’s contains_over_range_nil_comparison opt-in rule and updates existing code to prefer String.contains(...) over range(of:) != nil / == nil, improving clarity while preserving boolean semantics.

Changes:

• Adds contains_over_range_nil_comparison to .swiftlint.yml only_rules.
• Refactors URL/request matching stubs in test helpers to use contains.
• Updates a few production code paths to use contains for substring checks.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
Tests/WordPressKitTests/WordPressKitTests/Tests/RemoteTestCase.swift	Replaces range(of:) != nil endpoint matching with contains(...) ?? false in stub helpers.
Tests/KeystoneTests/Tests/Services/NotificationSettingsServiceTests.swift	Updates stub condition to use contains(...) ?? false for endpoint matching.
Tests/KeystoneTests/Helpers/OHHTTPStubs+Helpers.swift	Updates shared stubbing helper to use contains(...) ?? false.
Sources/WordPressAuthenticator/Helpers/Authenticator/WordPressAuthenticator.swift	Replaces range(of:) != nil with contains when normalizing http:// to https://.
Modules/Sources/WordPressKit/WordPressOrgXMLRPCValidator.swift	Replaces range(of:) != nil checks with contains when detecting specific redirect HTML markers.
.swiftlint.yml	Enables the contains_over_range_nil_comparison SwiftLint rule.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[wpmobilebot]

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.