Enable SwiftLint rule: first_where

.swiftlint.yml

@@ -42,6 +42,9 @@ only_rules:
   # Prefer checking `isEmpty` over comparing to empty string literal `""`.
   - empty_string
 
+  # Prefer `first(where:)` over `filter { }.first`.
+  - first_where
+
   # When calling the `joined` method on an array of strings, omit an
   # explicit empty-string separator since that is the default.
   - joined_default_parameter

Modules/Sources/FormattableContentKit/FormattableContent/FormattableContent.swift

@@ -29,9 +29,9 @@ extension FormattableContent {
     }
 
     public func action(id: Identifier) -> FormattableContentAction? {
-        return actions?.filter {
+        return actions?.first(where: {
             $0.identifier == id
-        }.first
+        })
     }
 
     public func range(with url: URL) -> FormattableContentRange? {

Modules/Sources/WordPressKit/PlanServiceRemote.swift

@@ -201,7 +201,7 @@ open class PlanServiceRemote: ServiceRemoteWordPressComREST {
             await wordPressComRestApi.perform(.get, URLString: path, parameters: parameters, type: ZendeskSiteContainer.self)
                 .eraseToError()
                 .flatMap { container in
-                    guard let metadata = container.body.sites.filter({ $0.ID == siteID }).first?.zendeskMetadata else {
+                    guard let metadata = container.body.sites.first(where: { $0.ID == siteID })?.zendeskMetadata else {
                         return .failure(PlanServiceRemoteError.noMetadata)
                     }
                     return .success(metadata)

Tests/KeystoneTests/Tests/Extensions/URLHelpersTests.swift

@@ -17,7 +17,7 @@ class URLHelpersTests: XCTestCase {
         XCTAssertNotEqual(url.absoluteString, newURL.absoluteString)
 
         let components = URLComponents(url: newURL, resolvingAgainstBaseURL: false)
-        let cacheBusterQueryItem = components?.queryItems?.filter { $0.name == "_" }.first
+        let cacheBusterQueryItem = components?.queryItems?.first(where: { $0.name == "_" })
         XCTAssertNotNil(cacheBusterQueryItem?.value)
     }
 }

Tests/KeystoneTests/Tests/Features/Notifications/NotificationUtility.swift

@@ -51,7 +51,7 @@ class NotificationUtility {
         let dictionary = try JSONObject(fromFileNamed: "notifications-replied-comment.json")
         let body = dictionary["body"]
         let blocks = NotificationContentFactory.content(from: body as! [[String: AnyObject]], actionsParser: NotificationActionParser(), parent: WordPressData.Notification(context: context))
-        return blocks.filter { $0.kind == .comment }.first! as! FormattableCommentContent
+        return blocks.first(where: { $0.kind == .comment })! as! FormattableCommentContent
     }
 
     func mockCommentContext() throws -> ActionContext<FormattableCommentContent> {

Tests/KeystoneTests/Tests/Services/NotificationSettingsServiceTests.swift

@@ -52,9 +52,9 @@ class NotificationSettingsServiceTests: CoreDataTestCase {
         let targetSite = targetSettings.first!
         XCTAssert(targetSite.streams.count == 3, "Error while parsing Site Stream Settings")
 
-        let parsedDeviceSettings = targetSite.streams.filter { $0.kind == StreamKind.device }.first
-        let parsedEmailSettings = targetSite.streams.filter { $0.kind == StreamKind.email }.first
-        let parsedTimelineSettings = targetSite.streams.filter { $0.kind == StreamKind.timeline }.first
+        let parsedDeviceSettings = targetSite.streams.first(where: { $0.kind == StreamKind.device })
+        let parsedEmailSettings = targetSite.streams.first(where: { $0.kind == StreamKind.email })
+        let parsedTimelineSettings = targetSite.streams.first(where: { $0.kind == StreamKind.timeline })
 
         let expectedTimelineSettings = [
             "new_comment": false,
@@ -103,9 +103,9 @@ class NotificationSettingsServiceTests: CoreDataTestCase {
         let otherSettings = filteredSettings.first!
         XCTAssert(otherSettings.streams.count == 3, "Error while parsing Other Streams")
 
-        let parsedDeviceSettings = otherSettings.streams.filter { $0.kind == StreamKind.device }.first
-        let parsedEmailSettings = otherSettings.streams.filter { $0.kind == StreamKind.email }.first
-        let parsedTimelineSettings = otherSettings.streams.filter { $0.kind == StreamKind.timeline }.first
+        let parsedDeviceSettings = otherSettings.streams.first(where: { $0.kind == StreamKind.device })
+        let parsedEmailSettings = otherSettings.streams.first(where: { $0.kind == StreamKind.email })
+        let parsedTimelineSettings = otherSettings.streams.first(where: { $0.kind == StreamKind.timeline })
 
         let expectedDeviceSettings = [
             "comment_like": true,

WordPress/Classes/Services/JetpackScanService.swift

@@ -71,7 +71,7 @@ class JetpackScanService {
                         continue
                     }
 
-                    var threat = threats.filter({ $0.id == item.threatId }).first
+                    var threat = threats.first(where: { $0.id == item.threatId })
                     if item.status == .inProgress {
                         threat?.status = .fixing
                     }

WordPress/Classes/Utility/Universal Links/Migration/MigrationDeepLinkRouter.swift

@@ -46,7 +46,7 @@ struct MigrationDeepLinkRouter: LinkRouter {
 
     func handle(url: URL, shouldTrack track: Bool = false, source: DeepLinkSource? = nil) {
         guard let deepLinkPath = url.host,
-              let route = routes.filter({ $0.path.removingPrefix("/") == deepLinkPath }).first else {
+              let route = routes.first(where: { $0.path.removingPrefix("/") == deepLinkPath }) else {
             return
         }
 

WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewModel/RegisterDomainDetailsViewModel.swift

@@ -372,9 +372,9 @@ class RegisterDomainDetailsViewModel {
         section.rows[safe: addressSectionIndexHelper.postalCodeIndex]?.editableRow?.value = domainContactInformation.postalCode
         section.rows[safe: addressSectionIndexHelper.addressLine1]?.editableRow?.value = domainContactInformation.address1
         section.rows[safe: addressSectionIndexHelper.stateIndex]?.editableRow?.idValue = domainContactInformation.state
-        section.rows[safe: addressSectionIndexHelper.stateIndex]?.editableRow?.value = states?.filter {
+        section.rows[safe: addressSectionIndexHelper.stateIndex]?.editableRow?.value = states?.first(where: {
             return $0.code == domainContactInformation.state
-            }.first?.name
+            })?.name
     }
 
     private func updatePhoneSection(with domainContactInformation: DomainContactInformation) {
@@ -391,9 +391,9 @@ class RegisterDomainDetailsViewModel {
     private func updateContactInformationSection(with domainContactInformation: DomainContactInformation) {
         let section = sections[SectionIndex.contactInformation.rawValue]
         section.rows[safe: CellIndex.ContactInformation.country.rawValue]?.editableRow?.idValue = domainContactInformation.countryCode
-        section.rows[safe: CellIndex.ContactInformation.country.rawValue]?.editableRow?.value = countries?.filter {
+        section.rows[safe: CellIndex.ContactInformation.country.rawValue]?.editableRow?.value = countries?.first(where: {
             return $0.code == domainContactInformation.countryCode
-            }.first?.name
+            })?.name
         section.rows[safe: CellIndex.ContactInformation.email.rawValue]?.editableRow?.value = domainContactInformation.email
         section.rows[safe: CellIndex.ContactInformation.firstName.rawValue]?.editableRow?.value = domainContactInformation.firstName
         section.rows[safe: CellIndex.ContactInformation.lastName.rawValue]?.editableRow?.value = domainContactInformation.lastName

WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergGalleryUploadProcessor.swift

@@ -39,9 +39,9 @@ class GutenbergGalleryUploadProcessor: GutenbergProcessor {
 
             let classAttributes = imgClass.components(separatedBy: " ")
 
-            guard let imageIDAttribute = classAttributes.filter({ (value) -> Bool in
+            guard let imageIDAttribute = classAttributes.first(where: { (value) -> Bool in
                 value.hasPrefix(GutenbergImgUploadProcessor.imgClassIDPrefixAttribute)
-            }).first else {
+            }) else {
                 return
             }
 

WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergImgUploadProcessor.swift

@@ -21,9 +21,9 @@ class GutenbergImgUploadProcessor: GutenbergProcessor {
             }
             let classAttributes = imgClass.components(separatedBy: " ")
 
-            guard let imageIDAttribute = classAttributes.filter({ (value) -> Bool in
+            guard let imageIDAttribute = classAttributes.first(where: { (value) -> Bool in
                 value.hasPrefix(GutenbergImgUploadProcessor.imgClassIDPrefixAttribute)
-            }).first else {
+            }) else {
                 return
             }
 

WordPress/WordPressShareExtension/Sources/Services/AppExtensionsService.swift

@@ -127,7 +127,7 @@ extension AppExtensionsService {
     ///
     func isAuthorizedToUploadMedia(in sites: [RemoteBlog], for selectedSiteID: Int) -> Bool {
         let siteID = NSNumber(value: selectedSiteID)
-        guard let isAuthorizedToUploadFiles = sites.filter({$0.blogID == siteID}).first?.isUploadingFilesAllowed() else {
+        guard let isAuthorizedToUploadFiles = sites.first(where: {$0.blogID == siteID})?.isUploadingFilesAllowed() else {
             return false
         }
 

WordPress/WordPressShareExtension/Sources/UI/ShareCategoriesPickerViewController.swift

@@ -82,7 +82,7 @@ class ShareCategoriesPickerViewController: UITableViewController {
 
         // Add the default site to the selected list if it's empty.
         var selected = categoryInfo.selectedCategories ?? []
-        if selected.isEmpty, let defaultCategory = categoryInfo.allCategories?.filter({$0.categoryID == categoryInfo.defaultCategoryID }).first {
+        if selected.isEmpty, let defaultCategory = categoryInfo.allCategories?.first(where: {$0.categoryID == categoryInfo.defaultCategoryID }) {
             selected.append(defaultCategory)
         }
         self.selectedCategories = selected