Skip to content

Format files in preparation for JetpackSocial migration#25539

Merged
crazytonyli merged 1 commit into
trunkfrom
task/jetpack-social-code-format-2
May 7, 2026
Merged

Format files in preparation for JetpackSocial migration#25539
crazytonyli merged 1 commit into
trunkfrom
task/jetpack-social-code-format-2

Conversation

@crazytonyli
Copy link
Copy Markdown
Contributor

Note

This PR will be merged after #25537

All changes are made with xcrun swift format to reduce noise in future PR diffs.

@crazytonyli crazytonyli added this to the 26.9 milestone May 6, 2026
@crazytonyli crazytonyli requested review from jkmassel and mokagio May 6, 2026 04:13
@dangermattic
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 6, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number32162
VersionPR #25539
Bundle IDorg.wordpress.alpha
Commitbf5f5e4
Installation URL7p2k3h2ivd6u8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 6, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number32162
VersionPR #25539
Bundle IDcom.jetpack.alpha
Commitbf5f5e4
Installation URL0hk47qpqq0un0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copy link
Copy Markdown
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does swift format work together with SwiftLint by the way? And, should we add a CI step to run the tool and fail if something changes to ensure all files are always up-to-date formatting wise?

@crazytonyli
Copy link
Copy Markdown
Contributor Author

The only incompatibility I noticed was the open_brace rule in swiftlint, which was fixed in https://github.com/wordpress-mobile/WordPress-iOS/pull/25513/changes#r3164261048.

Base automatically changed from task/jetpack-social-code-format to trunk May 7, 2026 02:30
@crazytonyli crazytonyli force-pushed the task/jetpack-social-code-format-2 branch from db3089c to bf5f5e4 Compare May 7, 2026 02:42
@crazytonyli crazytonyli enabled auto-merge May 7, 2026 02:42
@crazytonyli crazytonyli added this pull request to the merge queue May 7, 2026
Merged via the queue into trunk with commit 135539c May 7, 2026
24 checks passed
@crazytonyli crazytonyli deleted the task/jetpack-social-code-format-2 branch May 7, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants