Update photonlib to v2026.0.0-alpha-1 #165
Conversation
|
Wait why am I a participant in this |
|
Cause it was your tag lol |
|
Given that this is a pre-release, should it be published to the vendor json repo? |
I don't see a reason it shouldn't be, there's a long list of other pre-releases already in the repo. |
|
Is this intended to work with 2025? Do you want your users to upgrade to this? Partially a stability question. I would feel much more comfortable putting this in the 2026beta folder so only people doing new things get it. |
It's meant to be used with a 2025 release of WPILIB, as WPILIB hasn't released a beta for 2026 yet. When they do, we'll likely cut our beta. I understand the hesitancy, I'm just a little concerned about putting it in 2026beta as the 2026 branch of WPILIB isn't out yet. With that being said, I think it would be fine, but I'd like @Gold856 to weigh in as well. |
|
It's backwards compatible with 2025 on purpose, both because there's no beta, but also because I think it helps onboard potential alpha testers (no need to match library versions to the exact beta version). It's not intended for all users to upgrade to, and is in fact tagged alpha because of the potential for extra instability. It definitely does not belong in 2026beta (at least, not yet), so perhaps this PR can be closed if it's meant for more production quality versions to land in the stable years. |
|
If you add it to 2025 it will show up as the latest version and if anyone clicks update all they would get it. Will many teams be updating at this point? Probably not. Do you think the discovery of this new version (for people who want to test) will do more good than the potential unaware upgrade that could happen? |
|
Nah, I doubt the confusion is worth it. We specifically require matching photonlib and coprocessor versions. I'll just close it then, and hope anyone that wants to try it knows how to install the vendordep manually. |
4 participants
Automated changes by create-pull-request GitHub action