CP-310956: Remove legacy winbind configuration#6870
Draft
liulinC wants to merge 1 commit intoxapi-project:26.1-lcmfrom
Draft
CP-310956: Remove legacy winbind configuration#6870liulinC wants to merge 1 commit intoxapi-project:26.1-lcmfrom
liulinC wants to merge 1 commit intoxapi-project:26.1-lcmfrom
Conversation
9a468bf updated samba to 4.2x and keep legacy configuration in smb.conf conditionally for backward compatibility. Now samba binary is updated in all releases, this commit just drop the legacy configurations Signed-off-by: Lin Liu <lin.liu01@citrix.com>
changlei-li
approved these changes
Jan 29, 2026
Member
|
I can't accept this change right now, this will break xcp-ng 8.3. We can merge this in due time, but it might take weeks or even months, depending on the load of the xcp-ng packaging team |
Collaborator
Author
Thanks for the information. |
Member
|
I'll mark this as draft so maintainers don't keep wondering about the issue each time they need to do reviews |
Contributor
|
Just for context: this has been merged to master as bf61d51; so there is no urgency to merge it into LCM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9a468bf updated samba to 4.2x and keep legacy configuration in smb.conf conditionally for backward compatibility.
Now samba binary is updated in all releases, this commit just drop the legacy configurations
This is back port of #6822
This will make code simple and much easy to back port future commits to LCM.
I want @psafont to review for vates (XS no longer use old samba at all)