Skip to content

CP-310956: Remove legacy winbind configuration#6870

Draft
liulinC wants to merge 1 commit intoxapi-project:26.1-lcmfrom
liulinC:private/linl/backport
Draft

CP-310956: Remove legacy winbind configuration#6870
liulinC wants to merge 1 commit intoxapi-project:26.1-lcmfrom
liulinC:private/linl/backport

Conversation

@liulinC
Copy link
Collaborator

@liulinC liulinC commented Jan 29, 2026

9a468bf updated samba to 4.2x and keep legacy configuration in smb.conf conditionally for backward compatibility.

Now samba binary is updated in all releases, this commit just drop the legacy configurations

This is back port of #6822
This will make code simple and much easy to back port future commits to LCM.
I want @psafont to review for vates (XS no longer use old samba at all)

9a468bf updated samba to 4.2x and keep legacy configuration in
smb.conf conditionally for backward compatibility.

Now samba binary is updated in all releases, this commit just
drop the legacy configurations

Signed-off-by: Lin Liu <lin.liu01@citrix.com>
@liulinC liulinC requested a review from psafont January 29, 2026 01:14
@psafont
Copy link
Member

psafont commented Jan 29, 2026

I can't accept this change right now, this will break xcp-ng 8.3. We can merge this in due time, but it might take weeks or even months, depending on the load of the xcp-ng packaging team

@liulinC
Copy link
Collaborator Author

liulinC commented Jan 30, 2026

I can't accept this change right now, this will break in xcp-ng 8.3. We can merge this in due time, but it might take weeks or even months, depending on the lead of the xcp-ng packaging team

Thanks for the information.
So I will keep this PR open, and please let me know when it is time to go. 😄

@psafont
Copy link
Member

psafont commented Jan 30, 2026

I'll mark this as draft so maintainers don't keep wondering about the issue each time they need to do reviews

@psafont psafont marked this pull request as draft January 30, 2026 09:58
@lindig
Copy link
Contributor

lindig commented Jan 30, 2026

Just for context: this has been merged to master as bf61d51; so there is no urgency to merge it into LCM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants