Use XAPI to edit DNS entries within xsconsole#2
Merged
idruzhinin merged 1 commit intoxapi-project:masterfrom Jun 25, 2021
Merged
Conversation
Contributor
|
Please update the commit message with an explanation of why this was needed and what you changed. Quoting https://www.freecodecamp.org/news/writing-good-commit-messages-a-practical-guide/
|
Instead of directly editing `/etc/resolv.conf`, use XAPI to edit it. This fixes an issue where the changes weren't retained after a reboot because XAPI would override the changes with what was stored in its DB. Using XAPI to edit the DNS entries also applies the changes in XAPI's DB and so changes are kept after reboots. Signed-off-by: BenjiReis <benjamin.reis@vates.fr>
benjamreis
force-pushed
the
fix-DNS-storage-entries-by-xsconsole
branch
from
20c038e to
a14ee37
Compare
lindig
approved these changes
Jun 24, 2021
Collaborator
|
is #4 a pre-requisite for this change? Is there any particular order we should merge those? |
Contributor
Author
|
Hi! No, no particular order, all PRs are independent :) |
idruzhinin
approved these changes
Jun 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BenjiReis benjamin.reis@vates.fr