dialects: (riscv) Generic LiOp#5737
Open
osmanyasar05 wants to merge 4 commits intoxdslproject:mainfrom
Open
Conversation
superlopuh
reviewed
Mar 17, 2026
Collaborator
Author
|
@superlopuh I am not sure how to make the |
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Member
|
let's try this: add the LiOpHasCanonicalizationPatterns trait on subclasses instead, and do the code duplication necessary to make it work first, then we can take a look at simplifying? |
Member
|
CI is failing, let's take a look together? |
Collaborator
Author
yes, would be nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the load immediate operation to use the generic
LiOperationbase class.