This repository was archived by the owner on Oct 21, 2022. It is now read-only.
do not try to lookup SHA1 from tags in planex-pin#610
Open
edwintorok wants to merge 1 commit intomasterfrom
Open
do not try to lookup SHA1 from tags in planex-pin#610edwintorok wants to merge 1 commit intomasterfrom
edwintorok wants to merge 1 commit intomasterfrom
Conversation
The tag may not be a tag at all, but a commit hash, in which case the bitbucket lookup would fail. Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Contributor
Author
|
Although I think planex-clone would still fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tag may not be a tag at all, but a commit hash, in which case the
bitbucket lookup would fail.
We do not need to perform the sha1 lookup for planex-pin, so avoid it instead of throwing a 404.
Signed-off-by: Edwin Török edvin.torok@citrix.com