fix(cli): fix incorrect display of session creation time#439
fix(cli): fix incorrect display of session creation time#439k82cn merged 1 commit intoxflops:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request corrects the parsing of creation_time in the Rust SDK by removing an erroneous multiplication by 1000, ensuring timestamps are correctly interpreted as milliseconds. It also includes regression tests for Session and Application to prevent future regressions. I have no feedback to provide.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
RE: Codecov "Patch coverage 0% / 2 lines missing"This is a CI configuration blindspot, not a missing test. The 2 changed lines in The reason Codecov reports 0% is that - name: Cargo test
run: cargo test --workspace --exclude flame-rs --exclude cri-rs
- name: Generate coverage report
run: cargo tarpaulin --workspace --exclude flame-rs --exclude cri-rs ...So the new tests are never executed in CI → the 2 changed lines have no execution trace → patch coverage reads 0%. |
No description provided.