Add newest release and error logging #1655
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
force-pushed
the
11-26-add_newest_release_and_error_logging
branch
from
def55d5 to
8848b36
Compare
neekolas
force-pushed
the
11-26-add_newest_release_and_error_logging
branch
from
8848b36 to
e9159d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fork test error logging in
forks.cli.runForkTest, disableforks.config.otherOperations.createInstallationandsync, and bump bindings to1.6.2-rc1and SDK to4.5.0-rc2per newest releaseRefactors fork test error output to log
error?.message, broadens FAIL detection viahelpers.analyzer.PATTERNS.FAIL, disablescreateInstallationandsyncin fork config, and updates versions to node-bindings1.6.2-rc1and node-sdk4.5.0-rc2.📍Where to Start
Start with error handling in
forks.cli.runForkTestin cli.ts, then review the FAIL pattern addition in helpers/analyzer.ts.Macroscope summarized e9159d6.