Open
Conversation
from mod import Mod Mod(25, 35) // 12 should yield 5, because 5*12=60 which is 25 more the 35. The current implementation however leads to en error: >> Mod(25, 35) // 12 ValueError: the value (25 % 35) cannot be inverted Therefore I propose the change.
yoeo
requested changes
Jun 18, 2021
Owner
yoeo
left a comment
yoeo
left a comment
There was a problem hiding this comment.
Thanks for the pull request @hfwittmann,
This change is find with me, would you mind adding a unit-test that checks the issue you found ?
Division operator unit tests
I'll bump a new version with your fix as soon as it is merged.
And sorry for the late reply.
mod.py
Outdated
|
|
||
| inverted = (other * self.inverse) | ||
| return inverted.inverse | ||
| return self._value* converted.inverse |
Owner
There was a problem hiding this comment.
just to make the style-checker happy, could you add a space before the * ? :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from mod import Mod
Mod(25, 35) // 12
should yield 5, because 5*12=60 which is 25 more the 35.
The current implementation however leads to en error:
Therefore I propose the change.