feat: support inserting dragged nodes into connections#40
Draft
zacharyfmarion wants to merge 1 commit into
Draft
feat: support inserting dragged nodes into connections#40zacharyfmarion wants to merge 1 commit into
zacharyfmarion wants to merge 1 commit into
Conversation
996618f to
082df3c
Compare
Owner
Author
|
This both broke the existing working behavior when dragging from the node library and also does not work for dragging a node once its already in the node editor over a connection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
NodeCanvas.Why
Implementation notes
implementation-plans/node-drag-connection-insert.mdTesting
Coverage checklist
Validation performed
cargo check --workspacecargo test --workspacecargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkcargo bench --no-run --workspaceyarn lintyarn lint:cssnpx tsc -b --noEmityarn test src/components/edgeInsertion.test.tsnpx playwright testTest details
yarn build:wasmbefore TypeScript validation so the generated bindings existed fortsc.apps/web/.Performance
Performance impact
Justification
UI changes
Screenshots or recordings
Issue link