fix(protocol-contracts): ensure ProtocolStaking cooldown does not overflow
#1283
+18
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortendahl
reviewed
Nov 7, 2025
| function _setUnstakeCooldownPeriod(uint256 unstakeCooldownPeriod_) internal { | ||
| require(unstakeCooldownPeriod_ != 0, InvalidUnstakeCooldownPeriod()); | ||
| function _setUnstakeCooldownPeriod(uint48 unstakeCooldownPeriod_) internal { | ||
| require(unstakeCooldownPeriod_ != 0 && unstakeCooldownPeriod_ <= 365 days, InvalidUnstakeCooldownPeriod()); |
Contributor
There was a problem hiding this comment.
What's the rational behind putting this limit of one year?
Contributor
Author
There was a problem hiding this comment.
Any suggestion on a limit is good. We just wanted to limit to something so that the admin can't increase arbitrarily and lock all tokens.
Contributor
There was a problem hiding this comment.
We think one year is reasonable, were just curious on why this was set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.