feat(coprocessor): add ZK proof gauges to txn-sender #1437
Conversation
dartdart26
force-pushed
the
petar/txn-sender-verified-gauges
branch
from
ad3436a to
a9e16f9
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds two new Prometheus gauge metrics to monitor ZK proof processing in the transaction-sender service and changes the --host-chain-url CLI argument to long-only form (removing -h short form) to avoid conflict with the help flag.
Key changes:
- Added
coprocessor_verify_proof_resp_unsent_txn_gaugeto track verify proof responses waiting to be sent to the blockchain - Added
coprocessor_verify_proof_pending_gaugeto track proofs pending verification by zkproof-worker - Changed
--host-chain-urlfrom supporting both-hand--host-chain-urlto long-only--host-chain-url
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/metrics/metrics.md | Added documentation for two new ZK proof gauges with alarm recommendations; updated zkproof-worker section to clarify metrics are in transaction-sender |
| coprocessor/fhevm-engine/transaction-sender/src/metrics.rs | Implemented two new gauges with SQL queries to track pending and unsent verify proofs |
| coprocessor/fhevm-engine/transaction-sender/src/bin/transaction_sender.rs | Changed host_chain_url argument to long-only form to avoid -h conflict with help |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dartdart26
force-pushed
the
petar/txn-sender-verified-gauges
branch
from
a9e16f9 to
16ead6c
Compare
These cover both txn sending by `transaction-sender` and `zkproof-worker` operation. Also make `--host-chain-url` a long-only argument for compatibility with `-h` for help.
dartdart26
force-pushed
the
petar/txn-sender-verified-gauges
branch
from
16ead6c to
a89f9d7
Compare
| gateway_url: Url, | ||
|
|
||
| #[arg(short, long)] | ||
| #[arg(long)] |
There was a problem hiding this comment.
are you sure it's not used ?
There was a problem hiding this comment.
I think the full one is used everywhere, also in the values file. Not 100% sure if someone else is not using the short one though.
If I keep the short one, it doesn't even start on my end, complaining about -h.
@tawadaa Could you please check if only --host-chain-url is used and not -h?
These cover both txn sending by
transaction-senderandzkproof-workeroperation.Also make
--host-chain-urla long-only argument for compatibility with-hfor help.