fix(coprocessor): use block hash to identify transaction

[rudy-6-4]

No description provided.

[rudy-6-4]

add a test with duplicate transaction id that forms a transaction cycle without the block hash

[Copilot]

Pull request overview

This PR enhances transaction identification in the coprocessor system by adding block_hash and block_number fields alongside the existing transaction_id. This change enables proper identification of transactions that may be replayed or reorged across different blocks on the blockchain, which is critical for handling blockchain reorganizations correctly.

Key changes:

• Added block_hash and block_number fields to the AsyncComputation protobuf message
• Created a new Transaction type combining transaction_id and block_hash for unique identification
• Updated database schema with new columns and composite indexes
• Modified all SQL queries to use the composite key (transaction_id, block_hash) for transaction identification

Reviewed changes

Copilot reviewed 25 out of 29 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
coprocessor/proto/coprocessor.proto	Added block_hash and block_number fields to AsyncComputation message
coprocessor/fhevm-engine/scheduler/src/dfg/types.rs	Introduced Transaction struct and updated DFGTxResult to use it
coprocessor/fhevm-engine/scheduler/src/dfg.rs	Updated component node building to use Transaction type
coprocessor/fhevm-engine/scheduler/src/dfg/scheduler.rs	Updated scheduler logic to work with Transaction objects
coprocessor/fhevm-engine/tfhe-worker/src/tfhe_worker.rs	Modified queries and handlers to include block_hash in all operations
coprocessor/fhevm-engine/tfhe-worker/src/server.rs	Updated computation insertion to include block metadata
coprocessor/fhevm-engine/host-listener/src/database/tfhe_event_propagate.rs	Added block_hash to database insertion logic
coprocessor/fhevm-engine/host-listener/src/cmd/mod.rs	Updated block insertion to include block_hash
coprocessor/fhevm-engine/db-migration/migrations/*.sql	Added new database columns and indexes
coprocessor/fhevm-engine/tfhe-worker/src/tests/*.rs	Updated all test fixtures to include block_hash and block_number
coprocessor/fhevm-engine/tfhe-worker/benches/*.rs	Updated all benchmark fixtures to include block_hash and block_number
coprocessor/fhevm-engine/tfhe-worker/src/bin/cli.rs	Updated CLI smoke test to include new fields
coprocessor/fhevm-engine/tfhe-worker/src/utils.rs	Updated test utilities to include new fields
coprocessor/fhevm-engine/stress-test-generator/src/utils.rs	Updated stress test generator to include block_hash
coprocessor/fhevm-engine/.sqlx/*.json	Updated SQL query metadata files
coprocessor/fhevm-engine/Cargo.lock	Updated svm-rs and svm-rs-builds dependencies (unrelated change)

Files not reviewed (2)

• coprocessor/fhevm-engine/.sqlx/query-63f097acd50a5ec09f959668fce297d0c2c1c9851741c2a5bbb3238af2fe5b75.json: Language not supported
• coprocessor/fhevm-engine/.sqlx/query-b759c3143d1832a0f950a57fd3a795a87b98cd4267f5a858ab4f6320c8200209.json: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

[nitpick] The field order in this AsyncComputation struct initialization is inconsistent with the protobuf definition order. While Rust allows any field order, it's a best practice to match the definition order for maintainability. The correct order should be: inputs, is_allowed, block_hash, block_number. Consider reordering these fields to match the protobuf definition and the pattern used in other files.