fix(integer): fix StaticUnsignedBigInt cast into u128 #3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmontaigu
approved these changes
Nov 17, 2025
Contributor
tmontaigu
left a comment
tmontaigu
left a comment
There was a problem hiding this comment.
@tmontaigu reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mayeul-zama)
IceTDrinker
reviewed
Nov 18, 2025
mayeul-zama
force-pushed
the
mz/fix_bigint
branch
from
d0cc3f6 to
56440c9
Compare
IceTDrinker
reviewed
Nov 19, 2025
| } | ||
|
|
||
| impl<const N: usize> CastFrom<StaticUnsignedBigInt<N>> for u128 { | ||
| fn cast_from(input: StaticUnsignedBigInt<N>) -> Self { |
Member
There was a problem hiding this comment.
do we happen to have the same stuff for signed bigints ?
Contributor
Author
There was a problem hiding this comment.
Added tests for signed
IceTDrinker
reviewed
Nov 19, 2025
Member
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
just a question for now on whether we have similar bugs on other types
mayeul-zama
force-pushed
the
mz/fix_bigint
branch
from
56440c9 to
fe6f125
Compare
IceTDrinker
approved these changes
Nov 20, 2025
Member
IceTDrinker
left a comment
IceTDrinker
left a comment
There was a problem hiding this comment.
Thanks a lot !
@IceTDrinker reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tmontaigu)
mayeul-zama
force-pushed
the
mz/fix_bigint
branch
from
fe6f125 to
b323019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is