chore(gpu): optimize boolean ops by implementing them in cuda backend #3021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarbakadze
requested review from
agnesLeroy,
mayeul-zama and
tmontaigu
as code owners
bbarbakadze
requested review from
agnesLeroy
and removed request for
agnesLeroy
agnesLeroy
reviewed
Nov 19, 2025
Contributor
agnesLeroy
left a comment
agnesLeroy
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR @bbarbakadze! Here comes my review :)
bbarbakadze
force-pushed
the
bb/feat/boolean_ops
branch
3 times, most recently
from
8c79ced to
71eaf01
Compare
bbarbakadze
force-pushed
the
bb/feat/boolean_ops
branch
from
71eaf01 to
2439ab4
Compare
agnesLeroy
changed the title
agnesLeroy
changed the title
agnesLeroy
reviewed
Nov 19, 2025
agnesLeroy
reviewed
Nov 19, 2025
agnesLeroy
reviewed
Nov 19, 2025
bbarbakadze
force-pushed
the
bb/feat/boolean_ops
branch
from
2439ab4 to
28c4b29
Compare
agnesLeroy
reviewed
Nov 20, 2025
bbarbakadze
force-pushed
the
bb/feat/boolean_ops
branch
2 times, most recently
from
43b0fb0 to
f4efc1a
Compare
agnesLeroy
approved these changes
Nov 20, 2025
Contributor
agnesLeroy
left a comment
agnesLeroy
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot @bbarbakadze!
bbarbakadze
force-pushed
the
bb/feat/boolean_ops
branch
from
f4efc1a to
9ee98db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR content/description
Add boolean ops in Cuda backend, refactor some integer bitwise operations.
Check-list: