Skip to content

Conversation

@soonum
Copy link
Contributor

@soonum soonum commented Nov 24, 2025

The workflow might succeed even if it doesn't scan any parameters set. In this case the analysis duration would be much lower than usual. As being sent to a Slack channel, this message would warn maintainers about a possible issue.

Successfully tested here: https://github.com/zama-ai/tfhe-rs/actions/runs/19632084453/job/56214135392

@soonum soonum requested a review from nsarlin-zama November 24, 2025 11:19
@soonum soonum self-assigned this Nov 24, 2025
@soonum soonum added the ci label Nov 24, 2025
@cla-bot cla-bot bot added the cla-signed label Nov 24, 2025
@soonum soonum force-pushed the dt/ci/params_check_nigthly branch from b68ac27 to 2083203 Compare November 24, 2025 11:23
The workflow might succeed even if it doesn't scan any parameters
set or a smaller one. In this case the analysis duration would be
much lower than usual. As being sent to a Slack channel, this
improved message would warn maintainers about a potential issue.
@soonum soonum force-pushed the dt/ci/params_check_nigthly branch from 2083203 to 4f7ec9a Compare November 24, 2025 13:46
@nsarlin-zama
Copy link
Contributor

can we run this manually to check that it works as expected?

@soonum
Copy link
Contributor Author

soonum commented Nov 24, 2025

can we run this manually to check that it works as expected?

I did, on a mock run, check the link in the PR message.

Copy link
Contributor

@nsarlin-zama nsarlin-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks a lot!

@soonum soonum merged commit f45b7a9 into main Nov 25, 2025
182 checks passed
@soonum soonum deleted the dt/ci/params_check_nigthly branch November 25, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants