-
-
Notifications
You must be signed in to change notification settings - Fork 391
feat!: store-defined concurrency limits #3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
d-v-b
wants to merge
26
commits into
zarr-developers:main
Choose a base branch
from
d-v-b:feat/global-concurrency-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+629
−553
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
6c4e53f
add global concurrency limit instead of per-routine concurrency limits
d-v-b e98e6c0
add test
d-v-b 3b4b9c4
Merge branch 'main' into feat/global-concurrency-limit
d-v-b 735ee8e
lint
d-v-b d8fe042
Merge branch 'feat/global-concurrency-limit' of https://github.com/d-…
d-v-b 3ef6cfb
changelog
d-v-b 920cef7
Merge branch 'main' into feat/global-concurrency-limit
d-v-b e189474
Merge branch 'main' into feat/global-concurrency-limit
d-v-b f2e2b1b
Merge branch 'main' into feat/global-concurrency-limit
d-v-b 6aeb834
Merge branch 'main' of github.com:zarr-developers/zarr-python into fe…
d-v-b 229e3b3
move concurrency limiting logic to stores
d-v-b 05d191a
add store concurrency tests
d-v-b 5233bcd
Merge branch 'main' of github.com:zarr-developers/zarr-python into fe…
d-v-b 21fc1d5
remove more references to the global concurrency limit
d-v-b 9cec350
lint
d-v-b 1e73be9
use protocol
d-v-b 6febeaf
Merge branch 'main' of github.com:zarr-developers/zarr-python into fe…
d-v-b 17c7226
fix docstring
d-v-b f3d92f6
update docs, warn when config is used to set concurrency limits
d-v-b 127a024
use base class instead of protocol
d-v-b f2d8633
Merge branch 'main' into feat/global-concurrency-limit
d-v-b 60192ee
Merge branch 'main' into feat/global-concurrency-limit
d-v-b e86cedd
update changelog
d-v-b bf8c07d
remove unused or unneeded routines
d-v-b eb2d0c0
lint
d-v-b 96ecb4e
Merge branch 'main' into feat/global-concurrency-limit
d-v-b File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Moved concurrency-limiting functionality to store classes. The global configuration object no longer | ||
| controls concurrency limits. Concurrency limits, if applicable, must now be specified when constructing a store. | ||
| Users who have subclassed the `Store` class should implement concurrency-limiting logic if appropriate for | ||
| their storage backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: these comments are helpful for review now but will look odd in a while :)