Skip to content

feat: add colors for blink.cmp label matches#231

Merged
mcchrish merged 3 commits intozenbones-theme:mainfrom
rnxden:fix/blink-cmp-colors
May 4, 2026
Merged

feat: add colors for blink.cmp label matches#231
mcchrish merged 3 commits intozenbones-theme:mainfrom
rnxden:fix/blink-cmp-colors

Conversation

@rnxden
Copy link
Copy Markdown
Contributor

@rnxden rnxden commented Apr 14, 2026

Problem: cmp and blink.cmp are configured with different completion menu colors, when they should be (relatively) similar (for standardization/convention purposes).

Solution: Update blink.cmp colors to match those of cmp. Also added a color for BlinkCmpLabelMatch, the highlight for matched portions of completion items.

@rnxden
Copy link
Copy Markdown
Contributor Author

rnxden commented Apr 14, 2026

I also noticed that many other "match" colors, like telescope.nvim's TelescopeMatching and snack.nvim's SnacksPickerMatch are colored as palette.blossom, I'm wondering if that could be a better color for the completion menu matches too? Please let me know what your thoughts on this are.

@mcchrish
Copy link
Copy Markdown
Collaborator

mcchrish commented May 1, 2026

Hi @rnxden, I think it make sense to me. Let's give it a try. Can you show a screenshot of what will look like?

@rnxden
Copy link
Copy Markdown
Contributor Author

rnxden commented May 2, 2026

Of course:
image

Here's what it currently looks like:
image

The colors are darker but it fits the theme a bit more. If you'd like, we could keep the current one and instead update the cmp colors?

@rnxden
Copy link
Copy Markdown
Contributor Author

rnxden commented May 2, 2026

If you prefer the current colors, I wish to add the following highlights (currently used in my personal config) in order to add a match color (BlinkCmpLabelMatch) like so:
image

Let me know your thoughts on this. Thanks

@mcchrish
Copy link
Copy Markdown
Collaborator

mcchrish commented May 3, 2026

Thank you so much! I like the one with blossom color matching. Let's go for it.

@rnxden rnxden changed the title fix: align blink.cmp colors with cmp feat: add colors for blink.cmp label matches May 3, 2026
@rnxden
Copy link
Copy Markdown
Contributor Author

rnxden commented May 3, 2026

Thanks for the feedback! I've reverted the previous commit and added the changes for the blossom color matching (and updated the PR title to match the change more closely).

@mcchrish
Copy link
Copy Markdown
Collaborator

mcchrish commented May 4, 2026

Thanks! Merging.

@mcchrish mcchrish merged commit 3722934 into zenbones-theme:main May 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants