Skip to content

[GA11YFIX-442] table header accessibility for subscriptions page #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

[GA11YFIX-442] table header accessibility for subscriptions page #692

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
356116b
fix(subscriptions_page): improve subscription table for screen readers
elibezerra-svg Nov 5, 2025
10c5f61
fix(a11y): add accessible name to subscriptions table
elibezerra-svg Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/subscriptions_page.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<div class="container">
<header class="my-activities-header">
<h1>{{t 'following'}}</h1>
<h1 id="subscriptions-h1">{{t 'following'}}</h1>
</header>

<div class="my-activities-following-header">
Expand All @@ -44,13 +44,13 @@

<div id="main-content" class="requests">
{{#if subscriptions}}
<table class="table my-activities-table subscriptions-table">
<table class="table my-activities-table subscriptions-table" aria-labelledby="subscriptions-h1">
Copy link
Contributor

@jgorfine-zendesk jgorfine-zendesk Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks for working this in, here. 🙌

<thead>
<tr>
<th>{{t 'title'}}</th>
<th>{{t 'type'}}</th>
<th>{{t 'subscription'}}</th>
<th></th>
<th scope="col"><span class="visibility-hidden">{{t 'actions'}}</span></th>
</tr>
</thead>
<tbody>
Expand Down
Loading