Change ./ext/string requires to react/ext/string#55
Open
makevoid wants to merge 1 commit intozetachang:masterfrom
Open
Change ./ext/string requires to react/ext/string#55makevoid wants to merge 1 commit intozetachang:masterfrom
makevoid wants to merge 1 commit intozetachang:masterfrom
Conversation
Collaborator
|
@makevoid can you paste the error you're getting after |
Author
|
sure! here's the full repo https://github.com/makevoid/react-rb-builder |
|
I had errors due to the same require. Manually requiring 'react/ext/string' fixed them for now, but imho this pr should be merged. |
|
This issue was moved to ruby-hyperloop/hyper-react#55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found that there is a require error trying to bundle the code if the the ext/string path is not absolute (gem dir / path)
I think it works well when you are requiring the gem via
path: "./.."like you do in the examples (in fact they work) but it breaks otherwisefiy I'm on 2.1.6
Here's how to reproduce:
Gemfile
build.rb
run:
this pr should fix it
there is also some whitespace removal, If you want I can take it out from this PR and have just the two require lines as modified
also, very cool library! I will start to play with it soon! thanks!