Skip to content

Conversation

@puddly
Copy link
Contributor

@puddly puddly commented Nov 8, 2025

See home-assistant/core#156133.

The device switches modes. Color temperature is the only mode where we peek at attribute values to determine capabilities (all others just use the color_capabilities bitmap). The number of affected devices according to diagnostics is very small and all of the changes look reasonable to me.

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (54975cb) to head (945cf34).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #572   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files          63       63           
  Lines       10535    10535           
=======================================
  Hits        10222    10222           
  Misses        313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the original GLEDOPTO GL-C-009P issue, there's an old quirk that just removes the color cluster. If that were changed to a v2 quirk, it would also fix the issue.

But I agree this is the more proper fix. Going through the affected devices, the only devices we may wanna have a look at are:

There may be other we are missing, but I think this change should be fine (for the next major release). Only "important issue" may be this (and other?) LEDVANCE lights..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants