Add MietteSpanContents::with_name, improve docs, fix tests being compiled in downstream libraries, fix NamedSource's Debug impl #450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[cfg(test)]. Yes, LTO would eliminate them at link time most likely, but still, may improve compile times downstream a bit, and definitely better cleanliness wise unless I'm missing something. I did add modules to contain the tests, but I can undo that part if you rather - the#[cfg(all(test, feature = ..)]bit is enough.Debugimplementation forNamedSourcemissing call to.finish()#449 - callfinish, replace theOk(())with returning the result offinishHappy to split out this PR into 4 PRs if you prefer. Thanks for the awesome library!