Skip to content

Task/4 6 2026 1605 default dir if set should be used for extracts and other places wire into path gen logic#1688

Open
emily-howell wants to merge 6 commits intodevelopfrom
task/4_6_2026-1605-default_dir-if-set-should-be-used-for-extracts-and-other-places-wire-into-path-gen-logic
Open

Task/4 6 2026 1605 default dir if set should be used for extracts and other places wire into path gen logic#1688
emily-howell wants to merge 6 commits intodevelopfrom
task/4_6_2026-1605-default_dir-if-set-should-be-used-for-extracts-and-other-places-wire-into-path-gen-logic

Conversation

@emily-howell
Copy link
Copy Markdown
Member

No description provided.

@cyrush
Copy link
Copy Markdown
Member

cyrush commented Apr 13, 2026

Looks good, can we also add a test that tests the relay extract? (That is the most likely way users will leverage this)

@cyrush
Copy link
Copy Markdown
Member

cyrush commented Apr 13, 2026

Looks like an accidental commit on develop related to the pending viskores update:

a2c93b3

@cyrush
Copy link
Copy Markdown
Member

cyrush commented Apr 14, 2026

@emily-howell if you merge develop into this branch that will resolve the build issue

ascent.publish(data);
ascent.execute(actions);
ascent.close();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this case

…2026-1605-default_dir-if-set-should-be-used-for-extracts-and-other-places-wire-into-path-gen-logic
@cyrush cyrush added this to the 0.9.6 milestone Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default_dir, if set should be used for extracts and other places (wire into path gen logic)

2 participants