fix(splits): Make split assignment idempotent #10252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XL
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
axiomofjoy
reviewed
Nov 14, 2025
| }, {} as SplitState); | ||
| }, [splits, selectedPartialExamples]); | ||
| const handleSplitToggle = useCallback( | ||
| (selectedId: string) => { |
Contributor
There was a problem hiding this comment.
Suggested change
| (selectedId: string) => { | |
| (selectedSplitId: string) => { |
axiomofjoy
reviewed
Nov 14, 2025
Comment on lines
+112
to
+118
| if (!open && shouldKeepMenuOpenRef.current) { | ||
| shouldKeepMenuOpenRef.current = false; | ||
| setIsMenuOpen(true); | ||
| return; | ||
| } | ||
| shouldKeepMenuOpenRef.current = false; | ||
| setIsMenuOpen(open); |
Contributor
There was a problem hiding this comment.
Can we add a comment here explaining the need for this?
axiomofjoy
reviewed
Nov 14, 2025
Comment on lines
85
to
86
| const [isMenuOpen, setIsMenuOpen] = useState(false); | ||
| const shouldKeepMenuOpenRef = useRef(false); |
Contributor
There was a problem hiding this comment.
Probably worth a comment.
axiomofjoy
reviewed
Nov 14, 2025
| }, [splits, selectedPartialExamples]); | ||
| const handleSplitToggle = useCallback( | ||
| (selectedId: string) => { | ||
| onRequestKeepMenuOpen(); |
Contributor
There was a problem hiding this comment.
Might be worth a comment.
axiomofjoy
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Replaces add/remove split mutations with a single idempotent set-example-splits operation and updates the UI to use it with improved menu behavior.
addDatasetExamplesToDatasetSplitsandremoveDatasetExamplesFromDatasetSplitsinputs/mutations/payloads.setDatasetExampleSplitswithSetDatasetExampleSplitsInputandSetDatasetExampleSplitsMutationPayloadreturning a singleexample.src/phoenix/server/api/mutations/dataset_split_mutations.py):set_dataset_example_splitsto atomically set splits for anexample(validates IDs, deletes missing, inserts new; usesjoinedloadandtuple_).app/src/pages/examples/ExamplesSplitMenu.tsx):ExamplesSplitMenuSetDatasetExampleSplitsMutationand update apply logic to send fullsplitIdsperexampleId.onActionhandler and checkbox state sync.Written by Cursor Bugbot for commit 18bb22d. This will update automatically on new commits. Configure here.