Skip to content

Conversation

@szy21
Copy link
Member

@szy21 szy21 commented Dec 3, 2025

Purpose

These gradients are caculated here:

if turbconv_model isa AbstractEDMF
, so we don't need to calculate them again.

To-do

Content


  • I have read and checked the items on the review checklist.

Copy link
Member

@tapios tapios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szy21 szy21 added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2025
@szy21 szy21 added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 3, 2025
@szy21 szy21 added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit bdfa8c0 Dec 3, 2025
16 of 17 checks passed
@szy21 szy21 deleted the zs/hotfix branch December 3, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants