Skip to content

remove redundant computation of some gradient in prognostic edmf #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szy21 merged 1 commit into from
Dec 3, 2025
Merged

remove redundant computation of some gradient in prognostic edmf #4130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/cache/prognostic_edmf_precomputed_quantities.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,12 +300,6 @@ NVTX.@annotate function set_prognostic_edmf_precomputed_quantities_explicit_clos
end

(; ᶜgradᵥ_θ_virt, ᶜgradᵥ_q_tot, ᶜgradᵥ_θ_liq_ice) = p.precomputed
# First order approximation: Use environmental mean fields.
@. ᶜgradᵥ_θ_virt = ᶜgradᵥ(ᶠinterp(TD.virtual_pottemp(thermo_params, ᶜts))) # ∂θv∂z_unsat
ᶜq_tot = @. lazy(specific(Y.c.ρq_tot, Y.c.ρ))
@. ᶜgradᵥ_q_tot = ᶜgradᵥ(ᶠinterp(ᶜq_tot)) # ∂qt∂z_sat
@. ᶜgradᵥ_θ_liq_ice =
ᶜgradᵥ(ᶠinterp(TD.liquid_ice_pottemp(thermo_params, ᶜts))) # ∂θl∂z_sat
@. ᶜlinear_buoygrad = buoyancy_gradients( # TODO - do we need to modify buoyancy gradients based on NonEq + 1M tracers?
BuoyGradMean(),
thermo_params,
Expand Down
Loading