Add implicit interfaces for function hooks in Fortran module#2809
Open
joewallwork wants to merge 5 commits into
Open
Add implicit interfaces for function hooks in Fortran module#2809joewallwork wants to merge 5 commits into
joewallwork wants to merge 5 commits into
Conversation
Collaborator
Author
|
Huh, looks like ifx doesn't like externals with leading underscores. I hadn't tested this with that compiler yet (just flang). |
2 tasks
d249dc7 to
3c11497
Compare
Collaborator
Author
Fixed in 237ebc6 by prepending with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2808.
Merges into #2807.
As mentioned in the issue, it turns out that the interfacing to the special Enzyme function hooks can be done using implicit interfaces in Fortran. That is, you can get away without providing an explicit
interfaceblock like is done in the examples so long as you declarefor example.
Checklist
enzymemodulesquareexampleHooking up in the
allocatableArraySimpleexample will require fixing #2820.