Simplify checks in the derivation pipeline #296
Merged
+10
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch Inbox contract verifies the sender is legitimate.
shenkeyao
approved these changes
Dec 9, 2025
Member
shenkeyao
left a comment
shenkeyao
left a comment
There was a problem hiding this comment.
LGTM. Should we also update the wiki book to document this change?
Collaborator
Author
Yes. https://app.asana.com/1/1208976916964769/project/1209976130071762/task/1212358918705029?focus=true |
QuentinI
approved these changes
Dec 10, 2025
philippecamacho
merged commit 7113933
into
celo-integration-rebase-14.1
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://app.asana.com/1/1208976916964769/project/1209976130071762/task/1211892212379882?focus=true
This PR:
Simplifies the implementation of the function isValidBatchTx in order to prepare the implementation of the fallback mechanism. Indeed the change only consists of ignoring the check relative to the sender of the transaction as the Batch Inbox contract will reject the transaction if its sender is not a legitimate (i.e. active) batcher.
This PR does not:
Fully implement the fallback mechanism.