Fix Spack builds and Clang 22 with older version of Catch2#4197
Merged
Conversation
Member
Author
|
This was picked up by wiping the RedHat Spack build cache and forcing a run - that led to this issue being discovered (i.e. running on a clean cache). However, the Spack build cache is now failing again. |
jhale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue 1:
See https://github.com/catchorg/Catch2/blob/devel/docs/release-notes.md#3140.
"Suppressed the new Clang warning about COUNTER usage. (#3076)"
This raises a warning which results in an error due to our strict compiler flags. Can be removed once Catch 3.14 is available in Spack.
Issue 2:
Current
developbranch of Spack tools cannot correctly push/pull from the GitHub OCI registry. Pinning to v1.1.1 fixes this. It would probably be best to use stable releases of Spack tooling