[Fixes #2262] Support for PT-BR translation #2261
Conversation
…ets, annotations, usergroups, geostory, style editor, timeline, contextCreator, plugins). Fallback to English
…visualização" and "dashboard" to "painel"
Summary of ChangesHello @cmotadev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands GeoNode's localization capabilities by adding a comprehensive Brazilian Portuguese translation. This initiative aims to make the platform more accessible and user-friendly for Portuguese-speaking users in Brazil, covering a wide array of terms and UI elements within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
Hello! Thank you for this contribution. The Brazilian Portuguese translation is a great addition.
I've reviewed the files and found a few minor corrections to be made, mostly typos and some suggestions to improve the fluency of the sentences in Portuguese.
Additionally, I noticed that some keys in the JSON translation files contain typos (e.g., reasourceType, cannotPerfomAction, prompPendingChanges). As these seem to be existing issues in the source code (also present in the en-US.json file), I've maintained consistency and only corrected the translation values. It would be good to fix these keys in a future PR to maintain code quality.
Overall, great work!
geonode_mapstore_client/static/mapstore/gn-translations/data.pt-BR.json
Outdated
Show resolved
Hide resolved
geonode_mapstore_client/static/mapstore/gn-translations/data.pt-BR.json
Outdated
Show resolved
Hide resolved
| "attribution": "Atribuição", | ||
| "restriction": "Restrição", | ||
| "edition": "Edição", | ||
| "maintenanceFrequency": "Frequencia de manutenção", |
There was a problem hiding this comment.
The word 'Frequencia' is missing the acute accent. The correct form is 'Frequência'.
| "maintenanceFrequency": "Frequencia de manutenção", | |
| "maintenanceFrequency": "Frequência de manutenção", |
| "titlePlaceholder": "Digite um título...", | ||
| "fullscreen": "Tela cheia", | ||
| "nativescreen": "Sair do modo de tela cheia", | ||
| "prompPendingChanges": "Exitem mudanças ainda não salvas, tem certeza que você gostaria de abandoná-las?", |
There was a problem hiding this comment.
The word 'Exitem' contains a typo. The correct form is 'Existem'.
| "prompPendingChanges": "Exitem mudanças ainda não salvas, tem certeza que você gostaria de abandoná-las?", | |
| "prompPendingChanges": "Existem mudanças ainda não salvas, tem certeza que você gostaria de abandoná-las?", |
| "addLayer": "Adicionar camada", | ||
| "datasetsCatalogTitle": "Catálogo de camadas", | ||
| "datasetsCatalogFilterPlaceholder": "Filtrar conjuntos de dados por título ou resumo...", | ||
| "datasetsCatalogEntriesNoResults": "Não há resultados que correspondem a sua busca", |
There was a problem hiding this comment.
For better grammatical correctness, I suggest using the crase in 'à sua busca'. Also, the subjunctive verb 'correspondam' sounds more natural in this context.
| "datasetsCatalogEntriesNoResults": "Não há resultados que correspondem a sua busca", | |
| "datasetsCatalogEntriesNoResults": "Não há resultados que correspondam à sua busca", |
| "createApp": "Criar app", | ||
| "announcements": "Anúncios", | ||
| "inviteUsers": "Convidar usuários", | ||
| "addUser": "Adicioanr usuário", |
There was a problem hiding this comment.
The word 'Adicioanr' contains a typo. The correct form is 'Adicionar'.
| "addUser": "Adicioanr usuário", | |
| "addUser": "Adicionar usuário", |
| "publishResource": "Publicado", | ||
| "featureResource": "Destacado", | ||
| "advertiseResource": "Anunciado", | ||
| "preserveUploadedMetadataTooltip": "Manter o matadado ISO carregado, ao invés de gerá-lo", |
There was a problem hiding this comment.
The word 'matadado' contains a typo. The correct form is 'metadado'.
| "preserveUploadedMetadataTooltip": "Manter o matadado ISO carregado, ao invés de gerá-lo", | |
| "preserveUploadedMetadataTooltip": "Manter o metadado ISO carregado, ao invés de gerá-lo", |
|
|
||
| #: mapstore2_adapter/geoapps/geostories/__init__.py:36 | ||
| msgid "GeoStory Deleted" | ||
| msgstr "GeoStory Apagado" |
There was a problem hiding this comment.
To maintain consistency with the JSON translation file (data.pt-BR.json, line 217), I suggest using 'Excluído' instead of 'Apagado'.
msgstr "GeoStory Excluído"
|
|
||
| #: mapstore2_adapter/geoapps/geostories/__init__.py:36 | ||
| msgid "A GeoStory was deleted" | ||
| msgstr "Um GeoStory foi apagado" |
There was a problem hiding this comment.
To maintain consistency with the JSON translation file (data.pt-BR.json, line 217), I suggest using 'excluído' instead of 'apagado'.
msgstr "Um GeoStory foi excluído"
|
|
||
| #: mapstore2_adapter/geoapps/geostories/__init__.py:37 | ||
| msgid "A GeoStory was commented on" | ||
| msgstr "Um GeoStory foi comentado em" |
There was a problem hiding this comment.
The translation 'comentado em' is too literal and sounds a bit awkward in Portuguese. 'Um GeoStory foi comentado' is a more natural way to express the same idea.
msgstr "Um GeoStory foi comentado"
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
cmotadev
changed the title
…nd fits the overall tone of the interface better Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@giohappy I just noticed that this PR includes some translations that should be included in MapStore instead. @cmotadev FYI the content of the ms-translations is replaced every new build with the translations coming from the MapStore submodule, this means at the next js build the ms-translations/data.pt-BR.json will be automatically removed. For this reason we will need a separate PR for the translations in the MapStore repository https://github.com/geosolutions-it/MapStore2. Once the PR will be merged we will align the submodule in geonode-mapstore-client. I just opened the PR on MapStore geosolutions-it/MapStore2#11781 |
@allyoucanmap I did a fork from your repo to translate the cookie policy page. At least tomorrow I will finish it and send you a PR |
Pull request |
3 participants
Hello guys,
This is a first version of Brazilian Portuguese geonode-mapstore-client.
I don't know if it is 100% completed, but it covers a lot of terms, and it was enhanced from original Portuguese translation. This was based on geonode 4.4.3.
Please embed this translation as a "Suported Translations" on GeoNode, as below, on geonode's settings.py.
https://github.com/GeoNode/geonode/blob/6761e67bcdbfd4b1d9416fcf093a19333b3d0129/geonode/settings.py#L1483-L1497
I'm opening this PR here, but it will be referenced on geonode repo, too.
[]s