-
Notifications
You must be signed in to change notification settings - Fork 10
Get Storage Driver Use Case #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a new use case to retrieve storage driver configuration information for datasets, supporting the Dataverse API endpoint GET /datasets/{identifier}/storageDriver.
- Adds
GetDatasetStorageDriveruse case andStorageDrivermodel interface - Implements repository method in
DatasetsRepositoryand interface inIDatasetsRepository - Includes comprehensive unit and integration tests for the new functionality
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/datasets/domain/models/StorageDriver.ts |
Defines the StorageDriver interface with properties for storage configuration |
src/datasets/domain/useCases/GetDatasetStorageDriver.ts |
Implements the use case to retrieve storage driver information for a dataset |
src/datasets/domain/repositories/IDatasetsRepository.ts |
Adds method signature for getDatasetStorageDriver to the repository interface |
src/datasets/infra/repositories/DatasetsRepository.ts |
Implements the getDatasetStorageDriver method to call the API endpoint |
src/datasets/index.ts |
Exports the new getDatasetStorageDriver use case |
test/unit/datasets/GetDatasetStorageDriver.test.ts |
Adds unit tests for the use case with success and error scenarios |
test/integration/datasets/DatasetsRepository.test.ts |
Adds integration test to verify the repository method works with the API |
docs/useCases.md |
Documents the new use case with usage examples and parameter descriptions |
CHANGELOG.md |
Records the addition of the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What this PR does / why we need it:
Create Get Dataset Storage Driver use case
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes or changelog update needed for this change?:
yes, changelog updated
Additional documentation: