-
Notifications
You must be signed in to change notification settings - Fork 10
Address PR review feedback: fix documentation formatting and export StorageDriver model #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ChengShi-1 <[email protected]>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add Get Dataset Storage Driver use case
Address PR review feedback: fix documentation formatting and export StorageDriver model
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Addresses review feedback on PR #404 (Get Storage Driver use case):
docs/useCases.mdto match pattern used throughout the file (_See [use case](...) implementation_.)src/datasets/index.tsfor consistency with other domain models returned by "Get" use cases (e.g.,DatasetLinkedCollection,DatasetType)Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
The prettier format script was updated from a broad glob pattern to specific paths to avoid scanning
test/environment/docker-dev-volumesdirectories with permission restrictions.Suggestions on how to test this:
Verify that:
npm run buildsucceedsnpm run formatruns without permission errorsStorageDrivertype is importable from the package indexIs there a release notes or changelog update needed for this change?:
No - these are non-functional fixes to documentation and exports
Additional documentation:
N/A
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.