Skip to content

Conversation

Copy link

Copilot AI commented Dec 12, 2025

What this PR does / why we need it:

Addresses review feedback on PR #404 (Get Storage Driver use case):

  • Fixed documentation formatting: Corrected underscore escaping in docs/useCases.md to match pattern used throughout the file (_See [use case](...) implementation_.)
  • Exported StorageDriver model: Added model export in src/datasets/index.ts for consistency with other domain models returned by "Get" use cases (e.g., DatasetLinkedCollection, DatasetType)
  • Fixed build tooling: Updated prettier format script to avoid permission errors with docker volume directories

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

The prettier format script was updated from a broad glob pattern to specific paths to avoid scanning test/environment/docker-dev-volumes directories with permission restrictions.

Suggestions on how to test this:

Verify that:

  • npm run build succeeds
  • npm run format runs without permission errors
  • StorageDriver type is importable from the package index

Is there a release notes or changelog update needed for this change?:

No - these are non-functional fixes to documentation and exports

Additional documentation:

N/A


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copy link
Author

Copilot AI commented Dec 12, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 127.0.0.11
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 172.19.0.1
    • Triggering command: REDACTED, pid is -1 (packet block)
  • 8.8.8.8
    • Triggering command: REDACTED, pid is -1 (packet block)
  • analytics.localstack.cloud
    • Triggering command: /opt/code/localstack/.venv/bin/python /opt/code/localstack/.venv/bin/python -m localstack.runtime.main l/openssl/include /bin�� lude ssl/openssl/include u/13/cc1 (dns block)
  • api-inference.huggingface.co
    • Triggering command: /opt/java/openjdk/bin/java /opt/java/openjdk/bin/java -server -Xms512m -Xmx512m -XX:+UseG1GC -XX:+PerfDisableSharedMem -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=250 -XX:+UseLargePages -XX:+AlwaysPreTouch -XX:+ExplicitGCInvokesConcurrent -Xlog:gc*:file=/var/solr/logs/solr_gc.log:time,uptime:filecount=9,filesize=20M -Dsolr.jetty.inetaccess.includes= -Dsolr.jetty.inetaccess.excludes= -Dsolr.log.dir=/var/solr/logs -Djetty.port=8983 -DSTOP.PORT=7983 -DSTOP.KEY=solrrocks -Duser.timezone=UTC -XX:-OmitStackTraceInFastThrow (dns block)
  • api.mistral.ai
    • Triggering command: /opt/java/openjdk/bin/java /opt/java/openjdk/bin/java -server -Xms512m -Xmx512m -XX:+UseG1GC -XX:+PerfDisableSharedMem -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=250 -XX:+UseLargePages -XX:+AlwaysPreTouch -XX:+ExplicitGCInvokesConcurrent -Xlog:gc*:file=/var/solr/logs/solr_gc.log:time,uptime:filecount=9,filesize=20M -Dsolr.jetty.inetaccess.includes= -Dsolr.jetty.inetaccess.excludes= -Dsolr.log.dir=/var/solr/logs -Djetty.port=8983 -DSTOP.PORT=7983 -DSTOP.KEY=solrrocks -Duser.timezone=UTC -XX:-OmitStackTraceInFastThrow (dns block)
  • dataverse
    • Triggering command: /usr/bin/wait4x wait4x http http://dataverse:8080/api/info/version -i 8s -t 5m --expect-status-code 200 --expect-body-json data.version l/openssl/includnat 19.6�� lude 19.6/deps/uv/inc-s node_modules/@np172.18.0.0/16 19.6/deps/zlib lude 19.6/deps/v8/inc/tmp/runc-shim-error.log 19.6/deps/openss-j (dns block)
  • langchain4j.dev
    • Triggering command: /opt/java/openjdk/bin/java /opt/java/openjdk/bin/java -server -Xms512m -Xmx512m -XX:+UseG1GC -XX:+PerfDisableSharedMem -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=250 -XX:+UseLargePages -XX:+AlwaysPreTouch -XX:+ExplicitGCInvokesConcurrent -Xlog:gc*:file=/var/solr/logs/solr_gc.log:time,uptime:filecount=9,filesize=20M -Dsolr.jetty.inetaccess.includes= -Dsolr.jetty.inetaccess.excludes= -Dsolr.log.dir=/var/solr/logs -Djetty.port=8983 -DSTOP.PORT=7983 -DSTOP.KEY=solrrocks -Duser.timezone=UTC -XX:-OmitStackTraceInFastThrow (dns block)
  • metadata.google.internal
    • Triggering command: /opt/java/openjdk/bin/java /opt/java/openjdk/bin/java -cp /opt/payara/appserver/glassfish/domains/domain1/lib/ext/*:/opt/payara/appserver/glassfish/modules/glassfish.jar -Ddataverse.files.storage-driver-id=file1 -Ddataverse.pid.providers=fake -Ddataverse.pid.default-provider=fake -Ddataverse.pid.fake.type=FAKE -Ddataverse.pid.fake.label=FakeDOIProvider -Ddataverse.pid.fake.authority=10.5072 -Ddataverse.pid.fake.shoulder=FK2/ -Ddataverse.files.file1.type=file -Ddataverse.files.file1.label=Filesystem -Ddataverse.files.file1.directory=/store -Ddataverse.files.localstack1.type=s3 -Ddataverse.files.localstack1.label=LocalStack -Ddataverse.files.localstack1.custom-endpoint-url=http://localstack:4566 -Ddataverse.files.localstack1.custom-endpoint-region=us-east-2 -Ddataverse.files.localstack1.bucket-name=mybucket -Ddataverse.files.localstack1.path-style-access=true -Ddataverse.files.localstack1.upload-redirect=true (dns block)
  • phonehome.hazelcast.com
    • Triggering command: /opt/java/openjdk/bin/java /opt/java/openjdk/bin/java -cp /opt/payara/appserver/glassfish/domains/domain1/lib/ext/*:/opt/payara/appserver/glassfish/modules/glassfish.jar -Ddataverse.files.storage-driver-id=file1 -Ddataverse.pid.providers=fake -Ddataverse.pid.default-provider=fake -Ddataverse.pid.fake.type=FAKE -Ddataverse.pid.fake.label=FakeDOIProvider -Ddataverse.pid.fake.authority=10.5072 -Ddataverse.pid.fake.shoulder=FK2/ -Ddataverse.files.file1.type=file -Ddataverse.files.file1.label=Filesystem -Ddataverse.files.file1.directory=/store -Ddataverse.files.localstack1.type=s3 -Ddataverse.files.localstack1.label=LocalStack -Ddataverse.files.localstack1.custom-endpoint-url=http://localstack:4566 -Ddataverse.files.localstack1.custom-endpoint-region=us-east-2 -Ddataverse.files.localstack1.bucket-name=mybucket -Ddataverse.files.localstack1.path-style-access=true -Ddataverse.files.localstack1.upload-redirect=true (dns block)
  • s3.localhost.localstack.cloud
    • Triggering command: /opt/code/localstack/.venv/bin/python /opt/code/localstack/.venv/bin/python -m localstack.runtime.main l/openssl/include /bin�� lude ssl/openssl/include u/13/cc1 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add Get Dataset Storage Driver use case Address PR review feedback: fix documentation formatting and export StorageDriver model Dec 12, 2025
Copilot AI requested a review from ChengShi-1 December 12, 2025 08:07
@ChengShi-1 ChengShi-1 closed this Dec 12, 2025
@ChengShi-1 ChengShi-1 deleted the copilot/sub-pr-404 branch December 12, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants