-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ENG-4227] fix: makes environments optional in project template #4938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-4227] fix: makes environments optional in project template #4938
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Greptile OverviewGreptile SummaryThis PR makes the Key changes:
Issues found:
Confidence Score: 2/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
backend/src/ee/routes/v1/project-template-router.ts, line 75-93 (link)logic: missing early return for empty arrays - will fail validation checks on empty array
The
superRefineruns uniqueness/position validation even whenenvironmentsis empty ([]). Since you removed.min(1), users can now send empty arrays which will fail the position validation on line 86-92.
1 file reviewed, 2 comments
…x/make-env-optional-in-project-template
Description 📣
makes environments optional in project template
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets