ODOO-159: Refactor module structure by splitting core and enhanced fe… #9

zulquer · 2025-11-21T15:20:54Z

Module Restructure:

Renamed payment_multisafepay_official to payment_multisafepay (core module)
Created payment_multisafepay_enhaced module for business-specific features
Separated core payment functionality from enhanced custom features

Core Module (payment_multisafepay):

Refactored controllers/main.py for better maintainability
- Split large _get_order method into smaller focused helper methods
- Improved shopping cart line filtering using display_type blacklist
- Fixed webhook validation error handling (_set_error with state_message)
Enhanced payment_method.py with amount-based filtering
- Added minimum/maximum amount restrictions from MultiSafepay API
- Implemented availability reporting for debugging
Improved payment_provider.py with better multi-company support
- Added copy=False to multisafepay_api_key to prevent credential sharing
- Enhanced SDK initialization and configuration management
Updated payment_transaction.py for Odoo 19 compatibility
- Fixed method signatures for _set_done, _set_canceled, _set_error
- Improved refund handling with better validation
Added comprehensive i18n support (de_DE, es_ES, fr_FR, it_IT, nl_BE, nl_NL)

Enhanced Module (payment_multisafepay_enhaced):

Moved business-specific logic to separate module
Implemented pricelist-based payment method filtering
- Added _get_pricelist_from_context to retrieve pricelist from multiple sources
- Support for e-commerce, backend orders, and website contexts
- Automatic filtering based on allowed pricelists configuration
Enhanced payment transaction with custom refund reason tracking
Improved stock picking integration for order fulfillment
Enhanced account move integration for invoice management
Maintained all custom wizard and view functionality

Technical Improvements:

Better separation of concerns between core and custom features
Improved code organization and maintainability
Enhanced error handling and logging
Fixed Python method resolution order (MRO) for proper inheritance chain
Updated module dependencies and metadata

This refactoring provides a cleaner architecture where:

Core MultiSafepay functionality remains in the base module
Custom business logic lives in the enhanced module
Both modules can be maintained and deployed independently

…atures Major architectural improvements: Module Restructure: - Renamed payment_multisafepay_official to payment_multisafepay (core module) - Created payment_multisafepay_enhaced module for business-specific features - Separated core payment functionality from enhanced custom features Core Module (payment_multisafepay): - Refactored controllers/main.py for better maintainability * Split large _get_order method into smaller focused helper methods * Improved shopping cart line filtering using display_type blacklist * Fixed webhook validation error handling (_set_error with state_message) - Enhanced payment_method.py with amount-based filtering * Added minimum/maximum amount restrictions from MultiSafepay API * Implemented availability reporting for debugging - Improved payment_provider.py with better multi-company support * Added copy=False to multisafepay_api_key to prevent credential sharing * Enhanced SDK initialization and configuration management - Updated payment_transaction.py for Odoo 19 compatibility * Fixed method signatures for _set_done, _set_canceled, _set_error * Improved refund handling with better validation - Added comprehensive i18n support (de_DE, es_ES, fr_FR, it_IT, nl_BE, nl_NL) Enhanced Module (payment_multisafepay_enhaced): - Moved business-specific logic to separate module - Implemented pricelist-based payment method filtering * Added _get_pricelist_from_context to retrieve pricelist from multiple sources * Support for e-commerce, backend orders, and website contexts * Automatic filtering based on allowed pricelists configuration - Enhanced payment transaction with custom refund reason tracking - Improved stock picking integration for order fulfillment - Enhanced account move integration for invoice management - Maintained all custom wizard and view functionality Technical Improvements: - Better separation of concerns between core and custom features - Improved code organization and maintainability - Enhanced error handling and logging - Fixed Python method resolution order (MRO) for proper inheritance chain - Updated module dependencies and metadata This refactoring provides a cleaner architecture where: 1. Core MultiSafepay functionality remains in the base module 2. Custom business logic lives in the enhanced module 3. Both modules can be maintained and deployed independently

Apply automatic code formatting and linting fixes from OCA pre-commit hooks. This includes: - Code style improvements (black, isort, prettier) - Trailing whitespace removal - End-of-file fixes - Line length adjustments - Import sorting and organization - XML formatting improvements All changes are purely cosmetic and do not affect functionality

danielcivit

It works perfect. Very nice work. I left some comments - questions for your consideration, but the PR can be considered as approved.

danielcivit · 2025-12-05T15:20:59Z

payment_multisafepay/__manifest__.py

+    "website": "https://github.com//multisafepay",
+    "license": "AGPL-3",
+    "category": "eCommerce",
+    "version": "19.0.1.1.0",


Version should be 19.0.2.0.0.

I'm not sure about it, Because the name of the module is not the same as before. We should discuss about it.

danielcivit · 2025-12-05T15:23:23Z

payment_multisafepay_enhaced/__manifest__.py

+    "website": "https://github.com//multisafepay",
+    "license": "AGPL-3",
+    "category": "Accounting/Payment Providers",
+    "version": "19.0.1.1.0",


This is a new module. Version should be 19.0.1.0.0.

I don't know. We should discuss this. Versions in this context are related to the modules. And modules are renamed completely. So i'm not sure about this. Maybe we should create git submodules.

danielcivit · 2025-12-05T15:25:20Z

payment_multisafepay/views/payment_templates.xml

+        <script type="text/javascript">
+// Auto-submit form
+document.addEventListener("DOMContentLoaded", function () {
+    console.log("Auto-submitting MultiSafepay form...");


I know this was already there. For your consideration, let's remove this statement. Is not a good practice introduce this in production environment.

danielcivit · 2025-12-05T15:25:24Z

payment_multisafepay/views/payment_templates.xml

+    <template id="multisafepay_form" name="MultiSafepay Payment Form">
+        <!-- Basic debug -->
+        <script type="text/javascript">
+console.log("MultiSafepay Form Processing...");


I know this was already there. For your consideration, let's remove this statement. Is not a good practice introduce this in production environment.

danielcivit · 2025-12-05T15:26:25Z

payment_multisafepay/views/payment_templates.xml

+    if (form) {
+        form.submit();
+    } else {
+        console.error("Form not found!");


I know this was already there. For your consideration, let's remove this statement. I don't see the value in logging that message.

danielcivit · 2025-12-10T11:17:35Z

payment_multisafepay/models/payment_method.py

+                report, filtered_out, "amount", {"amount": amount}
+            )
+
+        # Note: Pricelist filtering moved to payment_multisafepay_enhaced module (custom feature)


Can we get rid of these notes? Why do we need it?

danielcivit · 2025-12-10T11:18:16Z

payment_multisafepay/models/payment_method.py

+        # Return all non-MultiSafepay methods plus filtered MultiSafepay methods
+        return other_methods + allowed_multisafepay_methods
+
+    # Note: _filter_by_pricelist() method moved to payment_multisafepay_enhaced module (custom feature)


Can we get rid of these notes? Why do we need it?

danielcivit · 2025-12-10T11:18:20Z

payment_multisafepay/models/payment_method.py

+        return other_methods + allowed_multisafepay_methods
+
+    # Note: _filter_by_pricelist() method moved to payment_multisafepay_enhaced module (custom feature)
+    # Note: _get_compatible_payment_methods_with_pricelist() method moved to payment_multisafepay_enhaced module (custom feature)


Can we get rid of these notes? Why do we need it?

danielcivit · 2025-12-10T14:14:26Z

payment_multisafepay/tests/test_payment_transaction.py

+
+        reference = self.env["payment.transaction"]._compute_reference("multisafepay")
+
+        print(f"🔍 Generated reference: {reference}")


Remove icon

danielcivit · 2025-12-10T14:18:46Z

payment_multisafepay/controllers/main.py

+            ),
+        )
+
+        # ⚠️ SALE MODULE INTEGRATION - Shipping Address


Remove icon

zulquer · 2025-12-17T12:42:02Z

.github/workflows/release.yml


      - name: Build project
-        run: ./bin/release.sh ${{ env.VERSION }}
+        run: ./release.sh ${{ env.VERSION }}


This is because, in this context, a folder at that level is considered an Odoo module, and 'bin' is not an Odoo module

payment_multisafepay/__manifest__.py

payment_multisafepay/models/__init__.py

payment_multisafepay/models/payment_method.py

payment_multisafepay/tests/test_payment_transaction.py

payment_multisafepay/views/payment_templates.xml

payment_multisafepay_enhaced/__manifest__.py

payment_multisafepay/controllers/main.py

payment_multisafepay/views/payment_templates.xml

zulquer · 2025-12-17T15:13:09Z

payment_multisafepay_enhaced/__manifest__.py

+    "author": "MultiSafepay",
+    "website": "https://github.com//multisafepay",
+    "license": "AGPL-3",
+    "category": "Accounting/Payment Providers",


This is good to find our modules. eccomerce now is not the a dependency mandatory so... the category should be.. "Provider" ... I do not know. Could we discuss about it.

zulquer · 2025-12-17T15:14:01Z

payment_multisafepay/views/payment_templates.xml

+    <template id="multisafepay_form" name="MultiSafepay Payment Form">
+        <!-- Basic debug -->
+        <script type="text/javascript">
+console.log("MultiSafepay Form Processing...");


Suggested change

console.log("MultiSafepay Form Processing...");

zulquer · 2025-12-17T15:15:13Z

payment_multisafepay_enhaced/__manifest__.py

@@ -0,0 +1,29 @@
+{
+    "name": "MultiSafepay Enhanced",


payment_multisafepay/views/payment_templates.xml

zulquer force-pushed the ODOO-159 branch from a05143d to d618122 Compare November 24, 2025 09:50

danielcivit and others added 5 commits November 25, 2025 16:54

Merge branch '19.0' into ODOO-159

14f358e

ODOO-159: Exclude ruff rules C901, B904

5545891

ODOO-159: Remove price_list_id from the core module

9792c1a

Merge branch 19.0 into ODOO-159

f68c840

danielcivit closed this Dec 10, 2025

danielcivit reopened this Dec 10, 2025

danielcivit closed this Dec 10, 2025

danielcivit reopened this Dec 10, 2025

danielcivit previously approved these changes Dec 10, 2025

View reviewed changes

zulquer commented Dec 17, 2025

View reviewed changes

Update payment_multisafepay/models/__init__.py

f6ed5e0

zulquer dismissed danielcivit’s stale review via f6ed5e0 December 17, 2025 12:54

zulquer added 10 commits December 17, 2025 13:55

Update payment_multisafepay/__manifest__.py

7ece45f

Update payment_multisafepay/models/__init__.py

5ce27fe

Update payment_multisafepay/models/payment_method.py

4bc8807

Update payment_multisafepay/models/payment_method.py

f28de92

Update payment_multisafepay/models/payment_method.py

8b7da43

Update payment_multisafepay/models/payment_method.py

b7c2ab5

Update payment_multisafepay/tests/test_payment_transaction.py

36263b4

Update payment_multisafepay/views/payment_templates.xml

1027e1b

Update payment_multisafepay/views/payment_templates.xml

c1aac0a

Update payment_multisafepay_enhaced/__manifest__.py

dcbb599

zulquer commented Dec 17, 2025

View reviewed changes

payment_multisafepay/controllers/main.py Outdated Show resolved Hide resolved

payment_multisafepay/views/payment_templates.xml Outdated Show resolved Hide resolved

zulquer added 2 commits December 17, 2025 15:51

Update payment_multisafepay/controllers/main.py

3e63272

Update payment_multisafepay/views/payment_templates.xml

f8702b3

zulquer commented Dec 17, 2025

View reviewed changes

payment_multisafepay/views/payment_templates.xml Outdated Show resolved Hide resolved

Update payment_multisafepay/views/payment_templates.xml

1294b0e


		reference = self.env["payment.transaction"]._compute_reference("multisafepay")

		print(f"🔍 Generated reference: {reference}")

ODOO-159: Refactor module structure by splitting core and enhanced fe… #9

Are you sure you want to change the base?

ODOO-159: Refactor module structure by splitting core and enhanced fe… #9

Uh oh!

Conversation

zulquer commented Nov 21, 2025

Uh oh!

danielcivit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants