[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

feg-adhoc · 2024-12-13T20:56:47Z

No description provided.

tate11 · 2025-01-15T21:18:41Z

Thank you for your effort. Gives a date error
time data '' does not match format '%d/%m/%Y'

Garanti Bankası 0 1 comma dot comma " %d/%m/%Y Date simple_value Amount Label

feg-adhoc · 2025-02-04T14:44:33Z

Hello @tate11 ! Thank you for your feedback. Could you please specify how the file you used for testing is structured and how the mapping is configured? I am unable to reproduce the error.

tate11 · 2025-02-04T16:16:09Z

Hello @tate11 ! Thank you for your feedback. Could you please specify how the file you used for testing is structured and how the mapping is configured? I am unable to reproduce the error.

In Turkey, the date is used as day/month/year. It gives an error while importing like this.

feg-adhoc · 2025-02-04T18:03:06Z

@tate11 You need to change the mapping configuration and set the timestamp format field to %d/%m/%Y, and it will work correctly.

tate11 · 2025-02-04T20:49:10Z

@tate11 You need to change the mapping configuration and set the timestamp format field to %d/%m/%Y, and it will work correctly.
#747 (comment)
I tried this when we opened the issue .I opened this issue on top of that.
If you want, I can put the sample bank CSV file here.

feg-adhoc · 2025-02-25T15:25:01Z

Hello @tate11 getting back to this… The tests you ran, were they done before the latest code changes? If so, it might be worth checking again with the updated version. Also, could you please share the sample bank CSV file? That would help me take a closer look.

tate11 · 2025-02-26T07:01:03Z

Hello @tate11 getting back to this… The tests you ran, were they done before the latest code changes? If so, it might be worth checking again with the updated version. Also, could you please share the sample bank CSV file? That would help me take a closer look.

Thank you very much I tested the latest status today and it works.
Screenshot 2025-02-26 at 09-58-11 BNK1 sample bank statement-01111.xls

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

Currently translated at 100.0% (99 of 99 strings) Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/zh_CN/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/

Currently translated at 100.0% (104 of 104 strings) Translation: bank-statement-import-17.0/bank-statement-import-17.0-account_statement_import_sheet_file Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_sheet_file/it/

…iles in addition to XLS and CSV formats

…ction

…parser header When importing an Excel file with a header and the field header_lines_skip_count is set to its default value (0), the header is retrieved using the -1 index (the last row). complementary to commit OCA@13285ab

feg-adhoc · 2025-11-06T13:16:30Z

@carlos-lopez-tecnativa Hi Carlos! I've applied the requested cherry-picks. I also confirmed that the changes you pointed to were already present in the code (which is likely why one of the commits was empty during the cherry-pick).

@pedrobaeza I believe this is ready to merge now!
Thanks!

Copilot

Copilot reviewed 42 out of 49 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

account_statement_import_sheet_file/models/account_statement_import_sheet_mapping.py

account_statement_import_sheet_file/models/account_journal.py

Copilot · 2025-11-06T13:17:11Z

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

+            )
+        transactions = list(
+            itertools.chain.from_iterable(
+                map(lambda line: self._convert_line_to_transactions(line), lines)


This 'lambda' is just a simple wrapper around a callable object. Use that object directly.

Suggested change

map(lambda line: self._convert_line_to_transactions(line), lines)

map(self._convert_line_to_transactions, lines)

Copilot · 2025-11-06T13:17:12Z

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

+        if original_currency == currency:
+            original_currency = None
+            if not amount:
+                amount = original_amount


Variable amount is not used.

Copilot · 2025-11-06T13:17:12Z

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

+            original_currency = None
+            if not amount:
+                amount = original_amount
+            original_amount = "0.0"


Variable original_amount is not used.

Suggested change

original_amount = "0.0"

Copilot · 2025-11-06T13:17:13Z

account_statement_import_sheet_file/models/account_statement_import.py

+        default=_get_default_mapping_id,
+    )
+
+    def _parse_file(self, data_file):


Mixing implicit and explicit returns may indicate an error, as implicit returns always return None.

Copilot · 2025-11-06T13:17:13Z

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

+                else currency_code
+            )
+
+            def _decimal(column_name, values):


Mixing implicit and explicit returns may indicate an error, as implicit returns always return None.

Copilot · 2025-11-06T13:17:13Z

account_statement_import_sheet_file/models/account_statement_import.py

+                return Parser.parse(
+                    data_file, self.sheet_mapping_id, self.statement_filename
+                )
+            except BaseException as exc:


Except block directly handles BaseException.

Suggested change

except BaseException as exc:

except Exception as exc:

Copilot · 2025-11-06T13:17:14Z

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py

+                except Exception:
+                    pass


'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

except Exception:

pass

except Exception as e:

# Could not convert column_name_or_index to int; skip it.

_logger.warning(

"Failed to convert '%s' to int in mapping for column '%s': %s",

column_name_or_index, column_name, e

)

Copilot · 2025-11-06T13:17:14Z

account_statement_import_sheet_file/__manifest__.py

+{
+    "name": "Bank Statement TXT/CSV/XLSX Import",
+    "summary": "Import TXT/CSV or XLSX files as Bank Statements in Odoo",
+    "version": "18.0.1.0.0",
+    "category": "Accounting",
+    "website": "https://github.com/OCA/bank-statement-import",
+    "author": "ForgeFlow, CorporateHub, Odoo Community Association (OCA)",
+    "maintainers": ["alexey-pelykh"],
+    "license": "AGPL-3",
+    "installable": True,
+    "depends": [
+        "account_statement_import_file",
+    ],
+    "external_dependencies": {"python": ["xlrd", "chardet"]},
+    "data": [
+        "security/ir.model.access.csv",
+        "data/map_data.xml",
+        "views/account_statement_import_sheet_mapping.xml",
+        "views/account_statement_import.xml",
+        "views/account_journal_views.xml",
+    ],
+}


This statement has no effect.

feg-adhoc · 2025-11-21T20:46:55Z

@OCA/banking-maintainers Hi! Could you help me merge this module?

pedrobaeza · 2025-11-22T08:41:08Z

@feg-adhoc there are up to 4 persons requesting changes to you. Please check their comments.

…vements

feg-adhoc · 2025-12-01T17:15:49Z

@pedrobaeza I've already made the necessary changes!

pedrobaeza · 2025-12-01T19:55:13Z

The other persons should now review. Please ping them.

rov-adhoc · 2025-12-01T20:00:16Z

@Daemo00 @carlos-lopez-tecnativa @victoralmau @cvinh
Could you please take a look at @feg-adhoc’s PR when you have a moment? Thanks in advance!

jbaudoux

Could you also include this fix ?

#805

I made a PR on your branch:

adhoc-dev#3

Daemo00

Nothing from my first review (more than 4 months ago) #747 (review) has been addressed or replied to.

The same was true when you requested a review update the last time (more than 2 months ago), see #747 (review).

feg-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch 5 times, most recently from 74d9ad5 to 3145831 Compare December 23, 2024 14:35

rov-adhoc approved these changes Jan 9, 2025

View reviewed changes

feg-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch 7 times, most recently from 00f7713 to 9d48f60 Compare February 4, 2025 14:43

matteotrubini reviewed Feb 28, 2025

View reviewed changes

account_statement_import_sheet_file/models/account_statement_import_sheet_parser.py Outdated Show resolved Hide resolved

rov-adhoc approved these changes Mar 18, 2025

View reviewed changes

feg-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch 5 times, most recently from e248a9a to 9c10eb1 Compare March 19, 2025 13:18

cav-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch from 9c10eb1 to 4425d1d Compare April 8, 2025 18:24

matteotrubini approved these changes Apr 9, 2025

View reviewed changes

OCA-git-bot added the approved label Apr 9, 2025

xtanuiha and others added 11 commits November 6, 2025 09:01

[IMP] account_statement_import_sheet_file: additional mapping controls

4f73fbd

[UPD] Update account_statement_import_sheet_file.pot

1411abc

[BOT] post-merge updates

38b4b74

[MIG] account_statement_import_sheet_file: Migration to 18.0

b3ed2b8

[FIX] account_statement_import_sheet_file: support for reading XLSX f…

2b90038

…iles in addition to XLS and CSV formats

[FIX] account_statement_import_sheet_file: Bugs with amount_type sele…

3a5d50e

…ction

Copilot AI review requested due to automatic review settings November 6, 2025 13:11

feg-adhoc force-pushed the 18.0-mig-account_statement_import_sheet_file branch from 4422b47 to f696ca8 Compare November 6, 2025 13:11

Copilot AI reviewed Nov 6, 2025

View reviewed changes

rov-adhoc approved these changes Nov 20, 2025

View reviewed changes

[FIX] account_statement_import_sheet_file: Test corrections and impro…

b0583b2

…vements

feg-adhoc requested review from Daemo00, carlos-lopez-tecnativa, cvinh and victoralmau December 1, 2025 17:13

rov-adhoc approved these changes Dec 1, 2025

View reviewed changes

jbaudoux approved these changes Dec 2, 2025

View reviewed changes

klosll approved these changes Dec 3, 2025

View reviewed changes

Daemo00 suggested changes Dec 5, 2025

View reviewed changes

	map(lambda line: self._convert_line_to_transactions(line), lines)
	map(self._convert_line_to_transactions, lines)

-                except Exception:
-                    pass
+                except Exception as e:
+                    # Could not convert column_name_or_index to int; skip it.
+                    _logger.warning(
+                        "Failed to convert '%s' to int in mapping for column '%s': %s",
+                        column_name_or_index, column_name, e
+                    )

Uh oh!

[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

Are you sure you want to change the base?

[18.0][MIG] account_statement_import_sheet_file: Migration to 18.0 #747

Uh oh!

Conversation

feg-adhoc commented Dec 13, 2024

Uh oh!

tate11 commented Jan 15, 2025

Uh oh!

feg-adhoc commented Feb 4, 2025

Uh oh!

tate11 commented Feb 4, 2025

Uh oh!

feg-adhoc commented Feb 4, 2025

Uh oh!

tate11 commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feg-adhoc commented Feb 25, 2025

Uh oh!

tate11 commented Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

feg-adhoc commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

feg-adhoc commented Nov 21, 2025

Uh oh!

pedrobaeza commented Nov 22, 2025

Uh oh!

feg-adhoc commented Dec 1, 2025

Uh oh!

pedrobaeza commented Dec 1, 2025

Uh oh!

rov-adhoc commented Dec 1, 2025

Uh oh!

jbaudoux left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daemo00 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

tate11 commented Feb 4, 2025 •

edited

Loading

tate11 commented Feb 26, 2025 •

edited

Loading

jbaudoux left a comment •

edited

Loading

Daemo00 left a comment •

edited

Loading