Skip to content

Conversation

@jbaudoux
Copy link

Allow to parse "123456" as 1234.56 when using "none" as decimal separator

Before it was returning "1.2.3.4.5.6" and crashing

@OCA-git-bot
Copy link
Contributor

Hi @alexey-pelykh,
some modules you are maintaining are being modified, check this out!

@jbaudoux jbaudoux force-pushed the 17-fix-account_statement_import_sheet_file-fix_sep_none branch from 77b3165 to ab2d6c5 Compare June 30, 2025 13:46
@jbaudoux jbaudoux changed the title [17.0][FIX] account_statement_import_sheet_file: fix none separator [17.0][FIX] account_statement_import_sheet_file: fix none decimal separator Jun 30, 2025
@alexey-pelykh
Copy link
Contributor

I'm not sure I'm aboard this the fix - if there's no decimal separator and 123456 is given, it should be parsed as 123456 - why should it work otherwise?

@jbaudoux
Copy link
Author

I'm not sure I'm aboard this the fix - if there's no decimal separator and 123456 is given, it should be parsed as 123456 - why should it work otherwise?

It will be parsed as 123456 if you configure there should be a separator and the value doesn't contain any.
The bank provides a file without separator and the currency has 2 decimals. When the amount 123456 is given, it means 1234.56
Before this it was adding a "." between each figure so I guess that option never worked and has never been used

@alexey-pelykh
Copy link
Contributor

It will be parsed as 123456 if you configure there should be a separator and the value doesn't contain any.

I think it calls for a documentation extension that "If no decimal delimiter is configured, ...... Example: ...."
Otherwise I'm good with the PR

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 2, 2025
@jbaudoux jbaudoux force-pushed the 17-fix-account_statement_import_sheet_file-fix_sep_none branch from ab2d6c5 to 0bb7b9d Compare December 2, 2025 09:18
@jbaudoux
Copy link
Author

jbaudoux commented Dec 2, 2025

help added on decimal separator field

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants