-
-
Notifications
You must be signed in to change notification settings - Fork 472
[17.0][FIX] account_statement_import_sheet_file: fix none decimal separator #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
[17.0][FIX] account_statement_import_sheet_file: fix none decimal separator #805
Conversation
|
Hi @alexey-pelykh, |
77b3165 to
ab2d6c5
Compare
|
I'm not sure I'm aboard this the fix - if there's no decimal separator and 123456 is given, it should be parsed as 123456 - why should it work otherwise? |
It will be parsed as 123456 if you configure there should be a separator and the value doesn't contain any. |
I think it calls for a documentation extension that "If no decimal delimiter is configured, ...... Example: ...." |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
ab2d6c5 to
0bb7b9d
Compare
|
help added on decimal separator field |
Allow to parse "123456" as 1234.56 when using "none" as decimal separator
Before it was returning "1.2.3.4.5.6" and crashing