Skip to content

Conversation

@glitchov
Copy link

@glitchov glitchov commented Sep 9, 2025

When importing bank statements, all payment return transactions are imported individually.
To improve the reconciliation performance, it's better to have an option to group all payment return in a one transaction.

Migration of #263

@glitchov glitchov force-pushed the 18.0-imp-account_statement_import_camt-hda branch from 9a2006b to 5909af0 Compare September 9, 2025 10:33
@baimont
Copy link

baimont commented Sep 15, 2025

When importing bank statements, all payment return transactions are imported individually. To improve the reconciliation performance, it's better to have an option to group all payment return in a one transaction.

Migration of #263

This does not really group in one transaction, it just sets some fields (partner_id, ...) to False when importing camt statements, right? Your boolean is therefore well renamed.

Could you then check in your unit test that these informations are ignored on transactions? And not just test the number of statement lines.

@baimont baimont force-pushed the 18.0-imp-account_statement_import_camt-hda branch from 5909af0 to b5db8c9 Compare September 16, 2025 13:40
@baimont baimont force-pushed the 18.0-imp-account_statement_import_camt-hda branch from b5db8c9 to d521055 Compare September 16, 2025 13:47
@baimont
Copy link

baimont commented Sep 16, 2025

Copy link

@gva-acsone gva-acsone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functional test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants