-
Notifications
You must be signed in to change notification settings - Fork 714
Fix Doctest Ci after jax bump #8724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8724 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 588 588
Lines 62640 62640
=======================================
Hits 62286 62286
Misses 354 354 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The biggest problem here is I cannot reproduce the fail locally by running the tested code (run sybil will reveal the same error but no helpful infi) @andrijapau so its hard to determine what happened and how to fix it |
This comment was marked as outdated.
This comment was marked as outdated.
|
https://github.com/PennyLaneAI/pennylane/actions/runs/19910786447/job/57078698810?pr=8724 The problem is I couldn't even locally reproduce these; in a standalone script things work very well. Moving them into the same python code then there's no issue anymore. So I guess somehow Sybil + Jax0.7.x have some scope issues here? |
Context:
After bump jax to 0.7.0 and 0.7.1, some doctests are affected. We fix them here
Description of the Change:
transform.pythe expected output tracing info need to be adjusted as the hashable versioncondition.pycontains some dynamic shape functionalities, which should be skipped for now, until the patch PR is merged.Benefits:
Documentation Tests should be back to normal and almost always green now (except for the mysterious
qmc.pywhich we have no clue yet)Possible Drawbacks:
N/A
Related GitHub Issues:
[sc-105091]