Enable Dynamic Shapes in Pennylane by Patching Jax locally #8525
+433
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hello. You may have forgotten to update the changelog!
|
JerryChen97
commented
Oct 23, 2025
JerryChen97
commented
Oct 23, 2025
JerryChen97
commented
Nov 21, 2025
JerryChen97
commented
Nov 21, 2025
JerryChen97
commented
Nov 21, 2025
JerryChen97
commented
Nov 21, 2025
JerryChen97
commented
Nov 21, 2025
This reverts commit de4c9a5.
albi3ro
reviewed
Nov 26, 2025
pennylane/workflow/_capture_qnode.py
Outdated
Comment on lines
276
to
279
| # Create JaxprEqnContext and TracingEqn for JAX 0.7.0 | ||
| # pylint: disable=import-outside-toplevel | ||
| from jax._src import compute_on, config, xla_metadata_lib | ||
| from jax._src.interpreters.partial_eval import JaxprEqnContext, TracingEqn |
Contributor
There was a problem hiding this comment.
Why do we need an import-outside-toplevel here?
albi3ro
reviewed
Nov 26, 2025
tests/capture/test_nested_plxpr.py
Outdated
|
|
||
| assert plxpr.eqns[0].primitive == ctrl_transform_prim | ||
| assert plxpr.eqns[0].params["control_values"] == [True] | ||
| # JAX 0.7.0 requires hashable params, so lists become tuples |
Contributor
There was a problem hiding this comment.
Not entirely sure we need these comments in the test. Even as a PR comment, it is a fairly obvious change.
mudit2812
reviewed
Nov 28, 2025
Comment on lines
58
to
59
| # TODO: use 0.7.0 after updating all the documentation | ||
| pip install sybil pytest "jax~=0.6.0" "jaxlib~=0.6.0" torch matplotlib pyzx |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 29, 2025
**Context:** Subset of #8525 focusing on hashability, as well as the jax API updates **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-102157] --------- Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Mudit Pandey <[email protected]>
**Context:** During the [updating](#8525) jax from `0.6.2` to `0.7.x` it's a huge headache how many random bugs there exist in new jax. However, we also do not wish to mutate any users' local environment by patching them globally. Therefore, inspired by Catalyst's elegant solution, here we put forward Pennylane's own and try to apply it. Note that to minimize any further unwanted inter-coupling between packages, Patchers were deliberated re-invented here. **Description of the Change:** All the jax patches will be localized and only be used by dynamic shape tests **Benefits:** Our patches to jax0.7.0 won't be cascading to any downstream package, or other packages sharing the same jax env. **Possible Drawbacks:** After bump jax to 0.7.0, dynamic shape won't be automatically available. Instead, one has to use the patching context mgr to run any dynamic shape related code. **Related GitHub Issues:**
JerryChen97
changed the title
Contributor
Author
|
Due to multiple decision made along the way (too convoluted so I omitted the details here, sorry!), this PR does not do the jax bump any more. Instead, it targets at enablement of our dynamic shapes by reasonably patching jax bugs |
JerryChen97
commented
Dec 1, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2025
------------------------------------------------------------------------------------------- **Context:** After bump jax to 0.7.0 and 0.7.1, some doctests are affected. We fix them here **Description of the Change:** 1. `transform.py` the expected output tracing info need to be adjusted as the hashable version 2. `condition.py` contains some dynamic shape functionalities, which should be skipped for now, until the [patch PR](#8525) is merged. **Benefits:** Documentation Tests should be back to normal and almost always green now (except for the mysterious `qmc.py` which we have no clue yet) **Possible Drawbacks:** N/A **Related GitHub Issues:** [sc-105091]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
[ ] bring back the doctests in
condition.pyskipped at #8724Context:
JAX updated their 0.7.x and 0.8.x recently (up to 23rd Oct 2025)
Many things changed, including:
DynamicJaxprTracerAPI changed a lotDescription of the Change:
Many patches, in alignment with Catalyst's patches
jax_extraBenefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-105046]