Exercise statement in pp_ctl.c: S_unwind_loop() #23954
Open
+28
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iabyn
reviewed
Nov 23, 2025
Per suggestion by Dave Mitchell in GH #23948, including comment re pp_return(). Per review: Ensure that only one warning was generated in newly added test block. Also, improve two test descriptions.
jkeenan
force-pushed
the
gh-23948-S_unwind_loop-20251122
branch
from
2a46fde to
8cadc1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestion by Dave Mitchell in GH #23948, including comment re pp_return().